You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/17 05:33:59 UTC

[GitHub] [kafka] dongjinleekr opened a new pull request #10339: MINOR: Remove redundant allows in import-control.xml

dongjinleekr opened a new pull request #10339:
URL: https://github.com/apache/kafka/pull/10339


   I found this problem while working on [KIP-719: Add Log4J2 Appender](https://cwiki.apache.org/confluence/display/KAFKA/KIP-719%3A+Add+Log4J2+Appender).
   
   1. `org.apache.log4j` don't need to be allowed in shell, trogdor subpackage; they uses `slf4j`, not `log4`.
   2. `org.slf4j` don't need to be allowed in clients, server subpackage: `org.slf4j` is allowed globally.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dongjinleekr commented on pull request #10339: MINOR: Remove redundant allows in import-control.xml

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10339:
URL: https://github.com/apache/kafka/pull/10339#issuecomment-800852370


   @chia7712 Of course. Here it is.
   
   +1. Congrats again for becoming a PMC member! :congratulations::congratulations::congratulations:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #10339: MINOR: Remove redundant allows in import-control.xml

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10339:
URL: https://github.com/apache/kafka/pull/10339


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dongjinleekr commented on pull request #10339: MINOR: Remove redundant allows in import-control.xml

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10339:
URL: https://github.com/apache/kafka/pull/10339#issuecomment-800808391


   @dajac @rondagostino @ijuma Could you have a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org