You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/15 08:41:10 UTC

[GitHub] [shardingsphere] codecov-commenter commented on pull request #6042: optimize lifecycle management of ShardingTransactionType

codecov-commenter commented on pull request #6042:
URL: https://github.com/apache/shardingsphere/pull/6042#issuecomment-643989941


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=h1) Report
   > Merging [#6042](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e6b41b1b6121d9af36d1492f98bde2336d8cf2f0&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6042/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #6042   +/-   ##
   =========================================
     Coverage     53.12%   53.13%           
     Complexity      438      438           
   =========================================
     Files          1188     1188           
     Lines         20928    20936    +8     
     Branches       3769     3770    +1     
   =========================================
   + Hits          11118    11124    +6     
   - Misses         9112     9113    +1     
   - Partials        698      699    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...driver/jdbc/adapter/AbstractConnectionAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/6042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvQWJzdHJhY3RDb25uZWN0aW9uQWRhcHRlci5qYXZh) | `71.57% <ø> (-0.30%)` | `6.00 <0.00> (ø)` | |
   | [...ransaction/ShardingTransactionTypeInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/6042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXRyYW5zYWN0aW9uLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3ByaW5nL3RyYW5zYWN0aW9uL1NoYXJkaW5nVHJhbnNhY3Rpb25UeXBlSW50ZXJjZXB0b3IuamF2YQ==) | `88.23% <66.66%> (-11.77%)` | `1.00 <0.00> (ø)` | |
   | [...tegy/ShardingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy95YW1sL3N3YXBwZXIvc3RyYXRlZ3kvU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `97.56% <0.00%> (-0.12%)` | `0.00% <0.00%> (ø%)` | |
   | [...y/KeyGenerateStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy95YW1sL3N3YXBwZXIvc3RyYXRlZ3kvS2V5R2VuZXJhdGVTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../swapper/ShardingRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6042/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy95YW1sL3N3YXBwZXIvU2hhcmRpbmdSdWxlQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `84.21% <0.00%> (+2.57%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=footer). Last update [c65060d...0fe424e](https://codecov.io/gh/apache/shardingsphere/pull/6042?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org