You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/09/07 05:36:54 UTC

[GitHub] carbondata pull request #1265: [CARBONDATA-1128] Add encoding for non-dictio...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1265#discussion_r137449599
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java ---
    @@ -366,7 +364,7 @@ private BitSet setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
         BitSet bitSet = new BitSet(numerOfRows);
         byte[][] filterValues = this.filterRangeValues;
         // binary search can only be applied if column is sorted
    -    if (isNaturalSorted) {
    +    if (isNaturalSorted && !dimensionColumnDataChunk.isNoDicitionaryColumn()) {
    --- End diff --
    
    why this check is required? even no dictionary columns also can be sorted right?


---