You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "shps951023 (via GitHub)" <gi...@apache.org> on 2026/10/21 03:13:58 UTC

[I] [Task] Add boundary tests for SimpleReadCacheSelector [fesod]

shps951023 opened a new issue, #1249:
URL: https://github.com/apache/fesod/issues/1249

   ### Motivation
   
   Good day team 🙌
   
   ### Motivation
   SimpleReadCacheSelector chooses between MapCache and Ehcache based on
   the shared-strings size. I did not find a dedicated selector test class
   in the current main branch.
   
   I would like to add focused tests for the existing selection behaviour.
   This is a test-coverage proposal, not a confirmed bug report.
   
   
   
   ### How to complete
   
   Add SimpleReadCacheSelectorTest using JUnit 5 and controllable
   PackagePart test doubles. Keep production code unchanged.
   
   ### Task List
   
   - [ ] Cover sizes below, equal to, and above the default threshold.
   - [ ] Cover a custom threshold.
   - [ ] Cover unknown sizes and IOException fallback.
   - [ ] Verify that known sizes do not require opening an input stream.
   
   ### Anything else?
   
   Stream ownership and cache lifecycle changes are out of scope.
   I will avoid overlapping with #1070.
   
   Is this scope useful, or is related coverage already planned?
   I would be happy to implement it once the scope is agreed upon. 🙌
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org


Re: [I] [Task] Add boundary tests for SimpleReadCacheSelector [fesod]

Posted by "shps951023 (via GitHub)" <gi...@apache.org>.
shps951023 commented on issue #1249:
URL: https://github.com/apache/fesod/issues/1249#issuecomment-6308830110

   Opened #1251 to add the focused SimpleReadCacheSelector tests. It covers default and custom threshold boundaries, unknown sizes, IOException fallback, and verifies that known sizes do not open an input stream. All 14 targeted cases and the repository-wide Spotless check pass locally on JDK 17. Production code, stream ownership, and cache lifecycle are unchanged; the work in #1070 remains out of scope.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org


Re: [I] [Task] Add boundary tests for SimpleReadCacheSelector [fesod]

Posted by "rajnish-verma-22172 (via GitHub)" <gi...@apache.org>.
rajnish-verma-22172 commented on issue #1249:
URL: https://github.com/apache/fesod/issues/1249#issuecomment-6307924405

   Hi, I would like to contribute to this test-coverage task. I understand the scope as a focused JUnit 5 SimpleReadCacheSelectorTest covering sizes below, at, and above the default threshold; a custom threshold; unknown sizes and IOException fallback; and verifying that known sizes do not open an input stream. I will keep production code unchanged and avoid the stream-ownership/cache-lifecycle work in PR #1070. The issue says implementation should wait for consensus. Please confirm this scope is useful and does not overlap with #1070 before I start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org