You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dhruvarya-db (via GitHub)" <gi...@apache.org> on 2026/09/01 23:37:07 UTC
[PR] test(transaction): add round-trip tests for transaction APIs against MemoryCatalog [iceberg-rust]
dhruvarya-db opened a new pull request, #3133:
URL: https://github.com/apache/iceberg-rust/pull/3133
Reviving #2392, which added these tests but was auto-closed as stale.
Most of the per-action tests in `transaction/mod.rs` only check the `ActionCommit` an action produces. Fast-append is already exercised end-to-end through a catalog (see `test_transaction_snapshot_summary` and `test_fast_append_with_row_lineage`), but the property, location, and multi-action paths don't have that kind of round-trip coverage yet. This adds it.
## Which issue does this PR close?
Part of #1322.
## What changes are included in this PR?
A new `test_commit_against_memory_catalog` module, built on the existing `make_v3_minimal_table_in_catalog` helper, covering:
* setting properties and reading them back after commit
* updating the table location
* chaining a property update and a location update, and checking it lands as a single metadata-log entry rather than two separate commits
* a chained transaction whose last action is invalid, checking the whole commit is rejected and the catalog is left untouched
The last two also fold in @andybradshaw's review feedback from #2392 (asserting the chained update is a single commit via the metadata-log length, and adding the failing-transaction case).
## Are these changes tested?
They are the tests. Ran them locally with `cargo test -p iceberg`; fmt and clippy are clean too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test(transaction): add round-trip tests for transaction APIs against MemoryCatalog [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3133:
URL: https://github.com/apache/iceberg-rust/pull/3133#issuecomment-5963584511
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test(transaction): add round-trip tests for transaction APIs against MemoryCatalog [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3133:
URL: https://github.com/apache/iceberg-rust/pull/3133#issuecomment-6091601442
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test(transaction): add round-trip tests for transaction APIs against MemoryCatalog [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3133: test(transaction): add round-trip tests for transaction APIs against MemoryCatalog
URL: https://github.com/apache/iceberg-rust/pull/3133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org