You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/08/06 12:56:18 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3562: HBASE-26169 Fix MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings

Apache9 commented on a change in pull request #3562:
URL: https://github.com/apache/hbase/pull/3562#discussion_r684213298



##########
File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java
##########
@@ -331,12 +331,12 @@ protected Path createInputFileListing(Job job) throws IOException {
     private Text getKey(Path path) {
       int level = conf.getInt(NUMBER_OF_LEVELS_TO_PRESERVE_KEY, 1);
       int count = 0;
-      String relPath = "";
+      StringBuilder relPath = new StringBuilder();

Review comment:
       Maybe a possible way is to store the path name in a list and then concat the list of strings from tail to head?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org