You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Thejas M Nair (JIRA)" <ji...@apache.org> on 2011/07/19 01:12:57 UTC
[jira] [Created] (PIG-2176) add logical plan assumption checker
add logical plan assumption checker
------------------------------------
Key: PIG-2176
URL: https://issues.apache.org/jira/browse/PIG-2176
Project: Pig
Issue Type: Improvement
Affects Versions: 0.9.0
Reporter: Thejas M Nair
Fix For: 0.9.0, 0.10
Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
Some of the assumptions that should be checked -
1. All schema have valid uid . (not -1).
2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2176) add logical plan assumption checker
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082812#comment-13082812 ]
Daniel Dai commented on PIG-2176:
---------------------------------
+1
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.10
>
> Attachments: PIG-2176.1.patch, PIG-2176.2.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-2176:
-------------------------------
Attachment: PIG-2176.2.patch
PIG-2176.2.patch - fixes issues found during unit test failures. Given that there were these unit test failures, there is some risk in the change, and that this is not a bug fix, i would push this into 0.10 only.
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.10
>
> Attachments: PIG-2176.1.patch, PIG-2176.2.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-2176:
-------------------------------
Status: Patch Available (was: Open)
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.10
>
> Attachments: PIG-2176.1.patch, PIG-2176.2.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-2176:
--------------------------------
Fix Version/s: (was: 0.9.0)
0.9.1
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.9.1, 0.10
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-2176:
-------------------------------
Fix Version/s: (was: 0.9.1)
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.10
>
> Attachments: PIG-2176.1.patch, PIG-2176.2.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-2176:
-------------------------------
Attachment: PIG-2176.1.patch
PIG-2176.1.patch - Checks validity of uid's in schema, each time after schema is reset. If uid -1 is found or if there are duplicate uid is found, it throws an exception. No test cases have been included as there is no known case where such invalid schema is generated.
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.9.1, 0.10
>
> Attachments: PIG-2176.1.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-2176:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed to trunk.
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Fix For: 0.10
>
> Attachments: PIG-2176.1.patch, PIG-2176.2.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2176) add logical plan assumption checker
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-2176:
-------------------------------
Assignee: Thejas M Nair
> add logical plan assumption checker
> ------------------------------------
>
> Key: PIG-2176
> URL: https://issues.apache.org/jira/browse/PIG-2176
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Fix For: 0.10.0
>
> Attachments: PIG-2176.1.patch, PIG-2176.2.patch
>
>
> Pig expects certain things about LogicalPlan, and optimizer logic depends on those to be true. Could that verifies that these assumptions are true will help in catching issues early on.
> Some of the assumptions that should be checked -
> 1. All schema have valid uid . (not -1).
> 2. All fields in schema have distinct uid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira