You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/06/16 09:55:58 UTC

[GitHub] [incubator-brpc] TousakaRin opened a new pull request #1143: remove blanks at end of line

TousakaRin opened a new pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143


   通过  sed -i -e 's/\s*$//' 删除 .h、.cpp、.sh、.py 文件的行尾空白字符


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] gydong commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
gydong commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-725776341


   @TousakaRin 代码有冲突


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] gydong removed a comment on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
gydong removed a comment on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-725775484


   > > 通过 sed -i -e 's/\s*$//' 删除 .h、.cpp、.sh、.py 文件的行尾空白字符
   > 
   > @TousakaRin 感觉可以按目录分批提交，每次改动的文件不太多，现在这样一次修改几百个文件不太好review
   
   ![Uploading image.png…]()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
serverglen commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-725248639


   > 通过 sed -i -e 's/\s*$//' 删除 .h、.cpp、.sh、.py 文件的行尾空白字符
   
   @TousakaRin 感觉可以按目录分批提交，每次改动的文件不太多，现在这样一次修改几百个文件不太好review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] TousakaRin commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
TousakaRin commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-870188572


   可能会破坏每一行的修改记录，这个pr先关闭了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] serverglen commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
serverglen commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-725827197


   > > > 通过 sed -i -e 's/\s*$//' 删除 .h、.cpp、.sh、.py 文件的行尾空白字符
   > > 
   > > 
   > > @TousakaRin 感觉可以按目录分批提交，每次改动的文件不太多，现在这样一次修改几百个文件不太好review
   > 
   > ![image](https://user-images.githubusercontent.com/3294444/98885221-995efe80-24cc-11eb-90c0-e212136daae5.png)
   
   nice


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] TousakaRin commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
TousakaRin commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-870188572


   可能会破坏每一行的修改记录，这个pr先关闭了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] TousakaRin closed pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
TousakaRin closed pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] gydong commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
gydong commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-725775789


   > > 通过 sed -i -e 's/\s*$//' 删除 .h、.cpp、.sh、.py 文件的行尾空白字符
   > 
   > @TousakaRin 感觉可以按目录分批提交，每次改动的文件不太多，现在这样一次修改几百个文件不太好review
   
   ![image](https://user-images.githubusercontent.com/3294444/98885221-995efe80-24cc-11eb-90c0-e212136daae5.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] gydong commented on pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
gydong commented on pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143#issuecomment-725775484


   > > 通过 sed -i -e 's/\s*$//' 删除 .h、.cpp、.sh、.py 文件的行尾空白字符
   > 
   > @TousakaRin 感觉可以按目录分批提交，每次改动的文件不太多，现在这样一次修改几百个文件不太好review
   
   ![Uploading image.png…]()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] TousakaRin closed pull request #1143: remove blanks at end of line

Posted by GitBox <gi...@apache.org>.
TousakaRin closed pull request #1143:
URL: https://github.com/apache/incubator-brpc/pull/1143


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org