You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/03/23 09:27:32 UTC

[GitHub] zeppelin pull request #2890: ZEPPELIN-3362. Unify ZeppelinContext of PythonI...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2890

    ZEPPELIN-3362. Unify ZeppelinContext of PythonInterpreter & IPythonInterpreter

    
    ### What is this PR for?
    
    Unify the ZeppelinContext of PythonInterpreter & IPythonInterpreter into one file to avoid code duplication. 
    
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3362
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3362

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2890
    
----
commit 4b2e206b394489e2a02f27d0b313396acbc40473
Author: Jeff Zhang <zj...@...>
Date:   2018-03-23T09:23:59Z

    ZEPPELIN-3362. Unify ZeppelinContext of PythonInterpreter & IPythonInterpreter

----


---

[GitHub] zeppelin issue #2890: ZEPPELIN-3362. Unify ZeppelinContext of PythonInterpre...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2890
  
    @felixcheung comments are addressed except https://github.com/apache/zeppelin/pull/2890#discussion_r176929872  which I plan to do in separate PR as it is not a trivial change I believe. 


---

[GitHub] zeppelin pull request #2890: ZEPPELIN-3362. Unify ZeppelinContext of PythonI...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2890


---

[GitHub] zeppelin issue #2890: ZEPPELIN-3362. Unify ZeppelinContext of PythonInterpre...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2890
  
    Thanks for the review @felixcheung , will do the improvement in another PR


---