You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2023/01/30 06:40:00 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1335: refactor(idl): unify the *.thrift files used by cpp and nodejs-client
acelyc111 opened a new pull request, #1335:
URL: https://github.com/apache/incubator-pegasus/pull/1335
https://github.com/apache/incubator-pegasus/issues/1283
This patch including changes:
- remove `nodejs-client/idl/*.thrift`
- remove generated python files from `nodejs-client/src/dsn/*.js`
- update workflow to generate js files before running `nodejs-client/test.sh`
- update module names which are related to `idl/*.thrift`, including renaming `nodejs-client/src/dsn/base_types.js` to `nodejs-client/src/dsn/dsn_types.js`
- update the license of `nodejs-client/src/dsn/dsn_types.js` to APLv2 because it is wrote manully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1335: refactor(idl): unify the *.thrift files used by cpp and nodejs-client
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1335:
URL: https://github.com/apache/incubator-pegasus/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org