You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/03/28 08:16:08 UTC
[PR] [SPARK-47623][PYTHON][CONNECT][TESTS] Use `QuietTest` in parity tests [spark]
zhengruifeng opened a new pull request, #45747:
URL: https://github.com/apache/spark/pull/45747
### What changes were proposed in this pull request?
1, add `def quiet` in both `ReusedPySparkTestCase` and `ReusedConnectTestCase`;
2, replace existing `QuietTest(self.sc)` with `self.quiet()`;
3, remove unnecessary parity test definitions;
### Why are the changes needed?
there are a lot of tests not enabled in parity test due to the usage of `sc` in `with QuietTest(self.sc)`, some of them were break into `def check_` and call the `check_` functions in the parity tests;
However, there are still such tests not enabled.
This PR aims to enable `QuietTest` within parity tests and make it easier to enable the remaining tests (`def check_` no longer needed).
### Does this PR introduce _any_ user-facing change?
no, test only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47623][PYTHON][CONNECT][TESTS] Use `QuietTest` in parity tests [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45747:
URL: https://github.com/apache/spark/pull/45747#issuecomment-2026333782
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47623][PYTHON][CONNECT][TESTS] Use `QuietTest` in parity tests [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #45747:
URL: https://github.com/apache/spark/pull/45747#discussion_r1542611572
##########
python/pyspark/testing/connectutils.py:
##########
@@ -184,6 +184,7 @@ def setUpClass(cls):
.remote(cls.master())
.getOrCreate()
)
+ cls._legacy_sc = PySparkSession._instantiatedSession._sc
Review Comment:
refer to `test_connect_basic`
https://github.com/apache/spark/blob/714feb7b5aec948c3499ad486dc63ea89a241ffa/python/pyspark/sql/tests/connect/test_connect_basic.py#L66-L68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47623][PYTHON][CONNECT][TESTS] Use `QuietTest` in parity tests [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45747: [SPARK-47623][PYTHON][CONNECT][TESTS] Use `QuietTest` in parity tests
URL: https://github.com/apache/spark/pull/45747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org