You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/09/05 17:48:38 UTC
[GitHub] [arrow] kevingurney opened a new pull request, #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
kevingurney opened a new pull request, #37578:
URL: https://github.com/apache/arrow/pull/37578
### Rationale for this change
In support of adding `arrow.array.Date64Array`, this pull request adds a new `arrow.type.Date64Type` class and associated `arrow.date64` construction function to the MATLAB interface.
### What changes are included in this PR?
1. New `arrow.type.Date46Type` class.
2. New `arrow.date64` construction function that returns an `arrow.type.Date64Type` instance.
3. New `arrow.type.ID.Date64` type enumeration value.
**Example**
```matlab
>> type = arrow.date64()
type =
Date64Type with properties:
ID: Date64
DateUnit: Millisecond
```
### Are these changes tested?
Yes.
1. Added a new `tDate64Type` test class.
2. Updated the `tID` test class to include `arrow.type.ID.Date64`.
### Are there any user-facing changes?
Yes.
1. There is a new public `arrow.type.Date64Type` class.
2. There is a new public `arrow.date64` construction function.
3. There is a new `arrow.type.ID.Date64` type enumeration value.
### Future Directions
1. #37572
2. #37577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37578:
URL: https://github.com/apache/arrow/pull/37578#issuecomment-1709655742
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 756a5d76e9b87958b11f14ffa497f507ccb48d6d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/16573073786) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sgilmore10 commented on a diff in pull request #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #37578:
URL: https://github.com/apache/arrow/pull/37578#discussion_r1316213760
##########
matlab/test/arrow/type/tDate64Type.m:
##########
@@ -0,0 +1,115 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements. See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied. See the License for the specific language governing
+% permissions and limitations under the License.
+
+classdef tDate64Type < hFixedWidthType
+% Test class for arrow.type.Date64Type and arrow.date64
Review Comment:
Can you move this above the license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney merged pull request #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #37578:
URL: https://github.com/apache/arrow/pull/37578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sgilmore10 commented on a diff in pull request #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #37578:
URL: https://github.com/apache/arrow/pull/37578#discussion_r1316213544
##########
matlab/src/matlab/+arrow/date64.m:
##########
@@ -0,0 +1,20 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements. See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied. See the License for the specific language governing
+% permissions and limitations under the License.
+
+function type = date64()
+%DATE64 Creates an arrow.type.Date64Type object
Review Comment:
Can you move this above the license header? Otherwise calling `help date64` will print the license header instead of this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37578:
URL: https://github.com/apache/arrow/pull/37578#issuecomment-1707101620
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on a diff in pull request #37578: GH-37230: [MATLAB] Add `arrow.type.Date64Type` class and `arrow.date64` construction function
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #37578:
URL: https://github.com/apache/arrow/pull/37578#discussion_r1316222217
##########
matlab/src/matlab/+arrow/date64.m:
##########
@@ -0,0 +1,20 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements. See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied. See the License for the specific language governing
+% permissions and limitations under the License.
+
+function type = date64()
+%DATE64 Creates an arrow.type.Date64Type object
Review Comment:
Fixed.
##########
matlab/test/arrow/type/tDate64Type.m:
##########
@@ -0,0 +1,115 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreements. See the NOTICE file distributed with
+% this work for additional information regarding copyright ownership.
+% The ASF licenses this file to you under the Apache License, Version
+% 2.0 (the "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS,
+% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+% implied. See the License for the specific language governing
+% permissions and limitations under the License.
+
+classdef tDate64Type < hFixedWidthType
+% Test class for arrow.type.Date64Type and arrow.date64
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org