You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/04/16 00:12:25 UTC
Re: Review Request 46160: Exposed zookeeper headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46160/
-----------------------------------------------------------
(Updated April 15, 2016, 6:12 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed Jie's comments.
Summary (updated)
-----------------
Exposed zookeeper headers.
Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171
Repository: mesos
Description (updated)
-------
Exposed zookeeper headers.
Diffs (updated)
-----
src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896
src/log/network.hpp 6d40027ec3c5e16c18a239042daba5c65aac4451
src/master/contender/contender.cpp 9ad62528ff57777cccfa693c2c6289f05060ece5
src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2
src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba
src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176
src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01
src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758
src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6
src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff
src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c
src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188
src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec
src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a
src/tests/zookeeper_test_server.hpp 1f1360e5ce06b2f4416dfedfe02642c7c8f7c9ae
src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94
src/tests/zookeeper_url_tests.cpp f6c50149bba95ccdadfd6ee97599069e2ddcd03d
src/zookeeper/authentication.hpp 40a233381e1e0efd2442efc95627d1968a925eae
src/zookeeper/authentication.cpp 62eab1cc9e85ce65314b9a317ab9d62b1d6d7e88
src/zookeeper/contender.hpp c4bb0bc408afcfc49ccc7823808373b8e00209d6
src/zookeeper/contender.cpp 4cda56cd1f46237387eb92bf938c448a9f370d02
src/zookeeper/detector.hpp 39a2241ec413d4bdfaa13cb040d71265ae510357
src/zookeeper/detector.cpp b184deb9357e4c23eba1fd2e2b2e1e60c2d0442d
src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b
src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f
src/zookeeper/url.hpp 1de7a082e444c8b8d22b599feaff0beaf5c45106
src/zookeeper/watcher.hpp dd948d05ff914bf8f1abfaa2d428a004515a97a4
src/zookeeper/zookeeper.hpp
src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833
Diff: https://reviews.apache.org/r/46160/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 46160: Exposed zookeeper headers.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46160/#review129225
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 15, 2016, 10:12 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46160/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 10:12 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed zookeeper headers.
>
>
> Diffs
> -----
>
> src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99
> src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896
> src/log/network.hpp 6d40027ec3c5e16c18a239042daba5c65aac4451
> src/master/contender/contender.cpp 9ad62528ff57777cccfa693c2c6289f05060ece5
> src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2
> src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba
> src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176
> src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01
> src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758
> src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6
> src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff
> src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c
> src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188
> src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
> src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec
> src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a
> src/tests/zookeeper_test_server.hpp 1f1360e5ce06b2f4416dfedfe02642c7c8f7c9ae
> src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94
> src/tests/zookeeper_url_tests.cpp f6c50149bba95ccdadfd6ee97599069e2ddcd03d
> src/zookeeper/authentication.hpp 40a233381e1e0efd2442efc95627d1968a925eae
> src/zookeeper/authentication.cpp 62eab1cc9e85ce65314b9a317ab9d62b1d6d7e88
> src/zookeeper/contender.hpp c4bb0bc408afcfc49ccc7823808373b8e00209d6
> src/zookeeper/contender.cpp 4cda56cd1f46237387eb92bf938c448a9f370d02
> src/zookeeper/detector.hpp 39a2241ec413d4bdfaa13cb040d71265ae510357
> src/zookeeper/detector.cpp b184deb9357e4c23eba1fd2e2b2e1e60c2d0442d
> src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b
> src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f
> src/zookeeper/url.hpp 1de7a082e444c8b8d22b599feaff0beaf5c45106
> src/zookeeper/watcher.hpp dd948d05ff914bf8f1abfaa2d428a004515a97a4
> src/zookeeper/zookeeper.hpp
> src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833
>
> Diff: https://reviews.apache.org/r/46160/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>