You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/24 18:21:38 UTC

[GitHub] [pulsar-helm-chart] nickelozz opened a new pull request #5: Fix namespace delete command in cleanup-helm-release.sh script

nickelozz opened a new pull request #5:
URL: https://github.com/apache/pulsar-helm-chart/pull/5


   ### Motivation
   
   While making use of the scripts provided in this repo to prepare helm releases, I noticed that providing the ```-d``` flag (delete namespace) for the ```./scripts/pulsar/cleanup_helm_release.sh``` would always fail claiming that the "namespace already exists". Upon closer examination, I noticed that the kubectl command to delete the provided namespace is actually attempting to create it instead.
   
   ### Modifications
   
   I've gone ahead and made the corresponding modification on the script to delete the namespace (went from ```kubectl create namespace ${namespace}``` to ```kubectl delete namespace ${namespace}```).
   
   ### Verifying this change
   
   I'm not sure what possible verifications I can provide for this PR. Please advise.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org