You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2017/07/28 11:34:48 UTC

[2/2] commons-numbers git commit: NUMBERS-13: Complex() passes all tests and meets all the C99 standards. This issue is closed.

NUMBERS-13: Complex() passes all tests and meets all the C99 standards. This issue is closed.


Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/387f4e09
Tree: http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/387f4e09
Diff: http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/387f4e09

Branch: refs/heads/complex-dev
Commit: 387f4e09b58d6d374a557a02093df887a8e8ebf8
Parents: a9437c9
Author: Eric Barnhill <er...@apache.org>
Authored: Fri Jul 28 13:36:53 2017 +0200
Committer: Eric Barnhill <er...@apache.org>
Committed: Fri Jul 28 13:36:53 2017 +0200

----------------------------------------------------------------------
 .../java/org/apache/commons/numbers/complex/CStandardTest.java  | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/387f4e09/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
----------------------------------------------------------------------
diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
index 6ec5460..ed0bf4f 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
@@ -96,14 +96,13 @@ public class CStandardTest {
 
     @Test
     public void testImplicitTrig() {
-        Complex z1 = new Complex(1.0);
+        Complex z1 = new Complex(3.0);
         Complex z2 = new Complex(0.0, 3.0); 
         assertComplex(z1.asin(), negI.multiply(z2.asinh()));
         assertComplex(z1.atan(), negI.multiply(z2.atanh()), Math.ulp(1), Math.ulp(1));
         assertComplex(z1.cos(), z2.cosh());
         assertComplex(z1.sin(), negI.multiply(z2.sinh()));
-        // CURRENTLY FAILS BELOW TEST
-        assertComplex(z1.tan(), negI.multiply(z1.tanh()));
+        assertComplex(z1.tan(), negI.multiply(z2.tanh()));
     }
 
     /**


[Numbers] C99 (Was: [...] git commit: [NUMBERS-13] is closed.)

Posted by Gilles <gi...@harfang.homelinux.org>.
Hi.

On Fri, 28 Jul 2017 11:34:48 -0000, ericbarnhill@apache.org wrote:
> NUMBERS-13: Complex() passes all tests and meets all the C99
> standards. This issue is closed.

Thanks for this work! :-)

Do you think of adding some info (in Javadoc, or in a "User guide")
about the new functionality (references and prominent features)?

Best,
Gilles

>
> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org