[GitHub] [jmeter] milamberspace commented on pull request #5812: Bug #5807 - Fix an ArrayIndexOutOfBoundsException on HTTP parameters …

["milamberspace (via GitHub)" <gi...@apache.org>]

milamberspace commented on PR #5812:
URL: https://github.com/apache/jmeter/pull/5812#issuecomment-1518602956

   >              String[] paramSplit = param.split("=");
   -            String name = decodeQuery(paramSplit[0]);
   +            String name = "";
   
   Is this OK? We use name further down to combine key/value-pairs with the same key.
   In the old implementation we would not get to the point, where name is not initialized, now, we would get there with a default value of "".
   Maybe use a null value of name to mean no valid key found and use that to deduce the bool noNameAndNoValue later (see my other comment about double negations).
   
   
   @FSchumacher  I change for initialize to null, works fine with params line like "k1=v1&=value&k2=v2" (JMeter display a name value empty in Parsed view and the value column contains "value"
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org