[GitHub] storm pull request #1621: Backport to 1.x [STORM-1766] - A better algorithm ...

[harshach <gi...@git.apache.org>]

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1621#discussion_r74524961
  
    --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/Cluster.java ---
    @@ -103,6 +103,9 @@ public Cluster(Cluster src) {
             this.status.putAll(src.status);
             this.topologyResources.putAll(src.topologyResources);
             this.blackListedHosts.addAll(src.blackListedHosts);
    +        if (src.networkTopography != null) {
    --- End diff --
    
    is this supposed to be == null. why are we creating new Map if there is one already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---