[GitHub] jacobrosenthal commented on issue #861: bsp: allow override of i2c, spis and spim pins

[GitBox <gi...@apache.org>]

jacobrosenthal commented on issue #861: bsp: allow override of i2c, spis and spim pins
URL: https://github.com/apache/mynewt-core/pull/861#issuecomment-369494475
 
 
   Hopefully I havent broken anything. But as a result Ive left nrf51-blenano and calliope_mini unchanged as they had existing definitions for i2c freq and I didnt want to break them (yet)
   
   Also of note, we have another inconsistency in that many nrf51 boards seem to create a spi_0_master and spi_1_slave but nrf52 boards seem to create an spi_0_slave. We could attempt to clean this up now, but again that would break existing bsps...
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services