You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2017/03/20 19:15:29 UTC
[GitHub] nifi-minifi-cpp pull request #70: MINIFI-226
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/70
MINIFI-226
DO NOT MERGE:
This is an early review of changes for MINIFI-226. First step will be to separate Configuring components from the FlowController. Next Controller services will be configurable and returned via the FlowConfiguration
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-226
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/70.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #70
----
commit 0db1116d5544409413f7302a645aa2475c9871dd
Author: Marc Parisi <ph...@apache.org>
Date: 2017-02-27T19:02:58Z
MINIFI-217: First commit. Updates namespaces and removes
use of raw pointers for user facing API.
commit edfea1ac2ac2ad82c185a32384406023accf57f3
Author: Marc Parisi <ph...@apache.org>
Date: 2017-03-13T14:47:05Z
MINIFI-217: Update based on PR and rebasing against master
commit d6774b32b40e36afbea80dd09495cceaa5db5233
Author: Marc Parisi <ph...@apache.org>
Date: 2017-03-20T19:12:51Z
MINIFI-226: First Step is to Separate YamlConfiguration from
FlowController.
Next step will be to Create Controller services, which will be easier
with the seperated FlowConfiguration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp pull request #70: MINIFI-226
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---