You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/15 08:30:31 UTC

[GitHub] [apisix-ingress-controller] okaybase commented on a change in pull request #374: fix: add compatibility logic for empty array when unmarshal json string to route

okaybase commented on a change in pull request #374:
URL: https://github.com/apache/apisix-ingress-controller/pull/374#discussion_r613864374



##########
File path: pkg/apisix/resource.go
##########
@@ -72,6 +72,27 @@ type item struct {
 	Value json.RawMessage `json:"value"`
 }
 
+type routeWrap v1.Route

Review comment:
       Yes, thanks for your suggestion! I have rewrite.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org