You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/11/17 10:00:00 UTC
[jira] [Resolved] (ARROW-13589) [C++] Reconcile ValidateArray and ValidateArrayFull
[ https://issues.apache.org/jira/browse/ARROW-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Pitrou resolved ARROW-13589.
------------------------------------
Resolution: Fixed
Issue resolved by pull request 11670
[https://github.com/apache/arrow/pull/11670]
> [C++] Reconcile ValidateArray and ValidateArrayFull
> ---------------------------------------------------
>
> Key: ARROW-13589
> URL: https://issues.apache.org/jira/browse/ARROW-13589
> Project: Apache Arrow
> Issue Type: Task
> Components: C++
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Minor
> Labels: pull-request-available
> Fix For: 7.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Instead of having entirely separate implementations for these functions, it seems the expensive checks can simply be toggled using a boolean flag inside a common implementation (as is already done for {{Scalar::Validate}}). Whether or not this makes the code more readable / shorter / more maintainable must be evaluated.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)