[GitHub] [lucene] uschindler commented on pull request #308: LUCENE-10113: Use VarHandles to access int/long/short types when reading from byte arrays (e.g. ByteArrayDataInput)

[GitBox <gi...@apache.org>]

uschindler commented on pull request #308:
URL: https://github.com/apache/lucene/pull/308#issuecomment-922492351


   > much better with the constants in BitUtil! it also better documents where little vs bigendian is being used.
   
   Exactly. I marked the BE ones as `@deprecated`, so we can get rid of them. Possibly also with Lucene 9.0! Some of them are tricky (like OfflinePointReader/Writer using BE because of lexical order), but the facet ones should really be changed.
   
   Looks that @iverase missed many hardcoded ones (those not using indexinput/output).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org