You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/12 12:50:21 UTC
[GitHub] [iotdb] Cpaulyz opened a new pull request, #7581: [IOTDB-4250][IOTDB-4628] Support multiple pipes and update drop semantics
Cpaulyz opened a new pull request, #7581:
URL: https://github.com/apache/iotdb/pull/7581
## Description
### IOTDB-4250
Support multiple pipes running at the same time.
### IOTDB-4628
In old version, pipe infomation will be stored even if pipe has been dropped. There are two advantages to not storing pipe infomation after drop can.
1. Support rollback logic in procedure better. If failed to create pipe, drop directlt.
2. Other modules(e.g.Trigger) do the same thing. Doing so can keep the semantics consistent in IoTDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #7581: [IOTDB-4250][IOTDB-4628] Support multiple pipes and update drop semantics
Posted by GitBox <gi...@apache.org>.
Cpaulyz commented on code in PR #7581:
URL: https://github.com/apache/iotdb/pull/7581#discussion_r996558004
##########
node-commons/src/main/java/org/apache/iotdb/commons/sync/metadata/SyncMetadata.java:
##########
@@ -150,69 +138,54 @@ public void checkAddPipe(PipeInfo pipeInfo) throws PipeException {
// check PipeSink exists
if (!isPipeSinkExist(pipeInfo.getPipeSinkName())) {
throw new PipeException(
- String.format("can not find PIPESINK %s.", pipeInfo.getPipeSinkName()));
+ String.format("Can not find PIPESINK [%s].", pipeInfo.getPipeSinkName()));
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7581: [IOTDB-4250][IOTDB-4628] Support multiple pipes and update drop semantics
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7581:
URL: https://github.com/apache/iotdb/pull/7581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a diff in pull request #7581: [IOTDB-4250][IOTDB-4628] Support multiple pipes and update drop semantics
Posted by GitBox <gi...@apache.org>.
neuyilan commented on code in PR #7581:
URL: https://github.com/apache/iotdb/pull/7581#discussion_r994281582
##########
node-commons/src/main/java/org/apache/iotdb/commons/sync/metadata/SyncMetadata.java:
##########
@@ -150,69 +138,54 @@ public void checkAddPipe(PipeInfo pipeInfo) throws PipeException {
// check PipeSink exists
if (!isPipeSinkExist(pipeInfo.getPipeSinkName())) {
throw new PipeException(
- String.format("can not find PIPESINK %s.", pipeInfo.getPipeSinkName()));
+ String.format("Can not find PIPESINK [%s].", pipeInfo.getPipeSinkName()));
}
Review Comment:
use PipeSinkNotExistException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org