You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/14 15:50:41 UTC
[GitHub] [skywalking-banyandb] DevPJ9 opened a new pull request, #191: Changes Of Issue #9759
DevPJ9 opened a new pull request, #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191
Added "In" and "Not_In" parsers in index_filter.go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1288401566
@hanahmily
`E:\Development_Java\OS\skywalking-banyandb>make -C pkg xx
make: Entering directory 'E:/Development_Java/OS/skywalking-banyandb/pkg'
process_begin: CreateProcess(NULL, git describe --tags --long, ...) failed.
../scripts/build/base.mk:33: pipe: No error
process_begin: CreateProcess(NULL, git rev-parse --abbrev-ref HEAD, ...) failed.
../scripts/build/base.mk:34: pipe: No error
make: *** No rule to make target 'xx'. Stop.
make: Leaving directory 'E:/Development_Java/OS/skywalking-banyandb/pkg'`
This is the error it is throwing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1280110996
> I am not sure how to execute these commands and where to. I tried to execute the commands on cmd, powershell and even on git bash. I have installed go as well but the commands are not working. I am doing it wrong. Can you please guide me through the steps.
It seems that you're new to Makefile. On Windows, you have to install a tool to run `make xxx` tasks. There are some [options](https://stackoverflow.com/questions/2532234/how-to-run-a-makefile-in-windows) for you.
I highly recommend you run these commands in a Ubuntu 20.x, either [WSL](https://ubuntu.com/tutorials/install-ubuntu-on-wsl2-on-windows-10#1-overview) or [a virtual machine](https://ubuntu.com/tutorials/how-to-run-ubuntu-desktop-on-a-virtual-machine-using-virtualbox#1-overview)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1300296390
You don't have to reopen another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1279606501
It looks good to me. But you have to format your codes before pushing.
After committing your local changes, please issue `make pre-push` as mentioned in https://github.com/apache/skywalking-banyandb/blob/main/CONTRIBUTING.md#test-your-changes-before-pushing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1300313736
For now, you keep staying on the new one. And keep all discussions on it for the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 closed pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 closed pull request #191: Changes Of Issue #9759
URL: https://github.com/apache/skywalking-banyandb/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1300308847
Ok. How should I proceed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1288414401
>
`xx` represents `lint`, `format` and etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1288560505
> @hanahmily I tried for `E:\Development_Java\OS\skywalking-banyandb>make -C pkg format` and `E:\Development_Java\OS\skywalking-banyandb>make -C pkg lint` as well and the error is :
>
> `make: Entering directory 'E:/Development_Java/OS/skywalking-banyandb/pkg' process_begin: CreateProcess(NULL, git describe --tags --long, ...) failed. ../scripts/build/base.mk:33: pipe: No error process_begin: CreateProcess(NULL, git rev-parse --abbrev-ref HEAD, ...) failed. ../scripts/build/base.mk:34: pipe: No error 'GOBIN' is not recognized as an internal or external command, operable program or batch file. make: *** [E:/Development_Java/OS/skywalking-banyandb/scripts/build/lint-bin.mk:4: E:/Development_Java/OS/skywalking-banyandb/scripts/build/../../bin/golangci-lint] Error 1 make: Leaving directory 'E:/Development_Java/OS/skywalking-banyandb/pkg'`
>
> does git have anything to do with this?
> @hanahmily I tried for `E:\Development_Java\OS\skywalking-banyandb>make -C pkg format` and `E:\Development_Java\OS\skywalking-banyandb>make -C pkg lint` as well and the error is :
>
> `make: Entering directory 'E:/Development_Java/OS/skywalking-banyandb/pkg' process_begin: CreateProcess(NULL, git describe --tags --long, ...) failed. ../scripts/build/base.mk:33: pipe: No error process_begin: CreateProcess(NULL, git rev-parse --abbrev-ref HEAD, ...) failed. ../scripts/build/base.mk:34: pipe: No error 'GOBIN' is not recognized as an internal or external command, operable program or batch file. make: *** [E:/Development_Java/OS/skywalking-banyandb/scripts/build/lint-bin.mk:4: E:/Development_Java/OS/skywalking-banyandb/scripts/build/../../bin/golangci-lint] Error 1 make: Leaving directory 'E:/Development_Java/OS/skywalking-banyandb/pkg'`
>
> does git have anything to do with this?
It needs git command available. Would you please join our slack channel through https://skywalking.apache.org/. I help you with it more conveniently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1279674475
>
I am using windows environment. Can I do the required steps in it as well? I checked the installation steps for banyanDb and there was only linux or mac were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1279613341
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/191?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#191](https://codecov.io/gh/apache/skywalking-banyandb/pull/191?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88f94d9) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/c8bb21aebf2a5bc189214d9da56d7787b64a6985?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8bb21a) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 43.07% 43.07%
=======================================
Files 81 81
Lines 8053 8053
=======================================
Hits 3469 3469
Misses 4282 4282
Partials 302 302
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1279891596
> make lint' are the minimal requirements. They're based on pure go tools.
I am not sure how to execute these commands and where to. I tried to execute the commands on cmd, powershell and even on git bash. I have installed go as well but the commands are not working. I am doing it wrong. Can you please guide me through the steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] Superskyyy commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1281579035
I also recommend using WSL but more times with simpler make commands you can just use Scoop to install make and it works like a charm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1288692522
Sure @hanahmily I have send the mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1282357354
Hey @hanahmily @Superskyyy `PRJ was unexpected at this time.
make: *** [Makefile:142: default] Error 255` this is the error which I am getting while using make commands. I am using chocolatey right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1288303893
> Author
There is a bash script at https://github.com/apache/skywalking-banyandb/blob/main/Makefile#L142, which doesn't work in Windows' CMD. You could run tasks in a subfolder `make -C pkg xx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1288439646
@hanahmily
`make: Entering directory 'E:/Development_Java/OS/skywalking-banyandb/pkg'
process_begin: CreateProcess(NULL, git describe --tags --long, ...) failed.
../scripts/build/base.mk:33: pipe: No error
process_begin: CreateProcess(NULL, git rev-parse --abbrev-ref HEAD, ...) failed.
../scripts/build/base.mk:34: pipe: No error
'GOBIN' is not recognized as an internal or external command,
operable program or batch file.
make: *** [E:/Development_Java/OS/skywalking-banyandb/scripts/build/lint-bin.mk:4: E:/Development_Java/OS/skywalking-banyandb/scripts/build/../../bin/golangci-lint] Error 1
make: Leaving directory 'E:/Development_Java/OS/skywalking-banyandb/pkg'`
does git have anything to do with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1279848328
> >
>
>
>
> I am using windows environment. Can I do the required steps in it as well? I checked the installation steps for banyanDb and only linux or mac were mentioned there.
WSL2 is a better solution for Windows.
If it is not the case, 'make format' and 'make lint' are the minimal requirements. They're based on pure go tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1300377006
Ok. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #191: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #191:
URL: https://github.com/apache/skywalking-banyandb/pull/191#issuecomment-1281868646
Thanks, @hanahmily @Superskyyy for your suggestions. I was overwhelmed with these many options and finally decided to install Ubuntu in VirtualBox. I am currently trying to run the make commands there. It is throwing some errors while running "make build". I will try some more, and if I cannot execute it, I will let you know. Thanks a lot for your suggestions and support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org