You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/05/14 19:12:10 UTC
Review Request 21423: OOZIE-1813 Add service to report/kill rogue bundles
and coordinator jobs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
Review request for oozie.
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On May 15, 2014, 10:54 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java, line 149
> > <https://reviews.apache.org/r/21423/diff/3/?file=581724#file581724line149>
> >
> > What happens if Oozie isn't configured to send emails? We should handle that gracefully.
I see your point. We will not send email if "TO_ADDRESS = CONF_PREFIX + "email.address"" is not configured.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review43175
-----------------------------------------------------------
On May 14, 2014, 6:42 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 6:42 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review43175
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment77244>
What happens if Oozie isn't configured to send emails? We should handle that gracefully.
- Robert Kanter
On May 14, 2014, 6:42 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 6:42 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review43003
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On May 14, 2014, 6:42 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 6:42 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review43804
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment78089>
Would it make sense to also add a log message with the same info as the email (formatting probably needs to be different)? This could be useful for users who didn't configure emails and have shouldKill=false; they can still get the information by looking at the log.
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment78088>
Can you add a log INFO message here? Otherwise, users may wonder why their coordinators got killed.
- Robert Kanter
On May 21, 2014, 1:28 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 1:28 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1813
> https://issues.apache.org/jira/browse/OOZIE-1813
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b77082c
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated Sept. 10, 2014, 6:28 p.m.)
Review request for oozie.
Bugs: OOZIE-1813
https://issues.apache.org/jira/browse/OOZIE-1813
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 14fd74c
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java d189ba8
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 412019e
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 25953bf
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/main/resources/oozie-default.xml 3a957d0
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Robert Kanter <rk...@cloudera.com>.
> On June 2, 2014, 11:54 p.m., Robert Kanter wrote:
> > Ship It!
With the individual log messages added in r8, I suppose we don't need to log the actual report
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review44577
-----------------------------------------------------------
On May 30, 2014, 7:41 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 7:41 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1813
> https://issues.apache.org/jira/browse/OOZIE-1813
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b77082c
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review44577
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Kanter
On May 30, 2014, 7:41 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 7:41 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1813
> https://issues.apache.org/jira/browse/OOZIE-1813
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b77082c
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated May 30, 2014, 7:41 p.m.)
Review request for oozie.
Changes
-------
Adding log statement.
Bugs: OOZIE-1813
https://issues.apache.org/jira/browse/OOZIE-1813
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b77082c
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated May 21, 2014, 1:28 a.m.)
Review request for oozie.
Bugs: OOZIE-1813
https://issues.apache.org/jira/browse/OOZIE-1813
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b77082c
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated May 21, 2014, 12:20 a.m.)
Review request for oozie.
Bugs: OOZIE-1813
https://issues.apache.org/jira/browse/OOZIE-1813
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java b77082c
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated May 17, 2014, 12:06 a.m.)
Review request for oozie.
Bugs: OOZIE-1813
https://issues.apache.org/jira/browse/OOZIE-1813
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated May 16, 2014, 9:51 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/
-----------------------------------------------------------
(Updated May 14, 2014, 6:42 p.m.)
Review request for oozie.
Repository: oozie-git
Description
-------
Report will be sent in html format, where each job is clickable and will take you to job info.
Coordinator id Coordinator name User name Group Kill Status
0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
Diff: https://reviews.apache.org/r/21423/diff/
Testing
-------
UTC
Thanks,
Purshotam Shah
Re: Review Request 21423: OOZIE-1813 Add service to report/kill rogue
bundles and coordinator jobs
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21423/#review42979
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java
<https://reviews.apache.org/r/21423/#comment76976>
Not familiar with NamedNativeQueries. Most likely needs to be tested with postgres/mysql.
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76964>
AbandonedCoordCheckerService.
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76967>
email.address
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76965>
Coordinators
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76970>
failure.limit
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76968>
kill.jobs
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76962>
CoordToMessage
core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java
<https://reviews.apache.org/r/21423/#comment76963>
Also add oozie base url in the message so that it is clear which server sends it.
core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java
<https://reviews.apache.org/r/21423/#comment76973>
Use a for loop and increment index as status is same.
If status is different put status in a array and index for status into the array and do in single for loop to reduce code verbosity.
Applicable for other test methods too.
- Rohini Palaniswamy
On May 14, 2014, 5:12 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21423/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 5:12 p.m.)
>
>
> Review request for oozie.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Report will be sent in html format, where each job is clickable and will take you to job info.
>
> Coordinator id Coordinator name User name Group Kill Status
> 0000000-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
> 0000001-140513184018277-oozie-puru-C COORD-TEST test testg Coord kill is disabled
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 332d02c
> core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7
> core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java e69de29
> core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java e69de29
>
> Diff: https://reviews.apache.org/r/21423/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>