You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by pr...@apache.org on 2017/10/30 21:14:10 UTC
[4/5] drill git commit: DRILL-5910: Logging exception when custom
AuthenticatorFactory not found
DRILL-5910: Logging exception when custom AuthenticatorFactory not found
closes #1013
Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/b0b7df10
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/b0b7df10
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/b0b7df10
Branch: refs/heads/master
Commit: b0b7df10da14ab94cd657f0c1e3a0c3ff242bedd
Parents: a4712c2
Author: vladimir <vt...@rightandabove.com>
Authored: Fri Oct 27 11:32:32 2017 +0300
Committer: Paul Rogers <pr...@maprtech.com>
Committed: Mon Oct 30 13:24:00 2017 -0700
----------------------------------------------------------------------
.../exec/rpc/security/ClientAuthenticatorProvider.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/drill/blob/b0b7df10/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java b/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
index 5cac208..697fb5a 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
@@ -57,17 +57,17 @@ public class ClientAuthenticatorProvider implements AuthenticatorProvider {
// then, custom factories
if (customFactories != null) {
- try {
- final String[] factories = customFactories.split(",");
- for (final String factory : factories) {
+ final String[] factories = customFactories.split(",");
+ for (final String factory : factories) {
+ try {
final Class<?> clazz = Class.forName(factory);
if (AuthenticatorFactory.class.isAssignableFrom(clazz)) {
final AuthenticatorFactory instance = (AuthenticatorFactory) clazz.newInstance();
authFactories.put(instance.getSimpleName(), instance);
}
+ } catch (final ReflectiveOperationException e) {
+ logger.error("Failed to create auth factory {}", factory, e);
}
- } catch (final ClassNotFoundException | IllegalAccessException | InstantiationException e) {
- throw new DrillRuntimeException("Failed to create auth factory.", e);
}
}