[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1415: Add redis cli to nightly image

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1415:
URL: https://github.com/apache/incubator-kvrocks/pull/1415#discussion_r1182312460


##########
Dockerfile:
##########
@@ -37,6 +37,10 @@ WORKDIR /kvrocks
 
 COPY --from=build /kvrocks/build/kvrocks ./bin/
 
+ARG TARGETARCH
+COPY tools/redis-cli-${TARGETARCH} /usr/bin/redis-cli
+RUN chmod a+x /usr/bin/redis-cli

Review Comment:
   IMHO if a user run `docker build` towards this dockerfile in him/her device instead of CI, a fatal error will appear since there is no `tools` dir.
   
   So I think It is not a reasonable change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org