[GitHub] incubator-ariatosca pull request #176: ARIA-237 Support for resuming failed ...

[ran-z <gi...@git.apache.org>]

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/176#discussion_r126684578
  
    --- Diff: tests/orchestrator/test_workflow_runner.py ---
    @@ -474,10 +483,62 @@ def test_resume_failed_task(self, workflow_context, thread_executor):
                 new_thread_executor.close()
     
             # Wait for it to finish and assert changes.
    +        node = workflow_context.model.node.refresh(node)
             assert node.attributes['invocations'].value == task.max_attempts - 1
             assert task.status == task.SUCCESS
             assert wf_runner.execution.status == wf_runner.execution.SUCCEEDED
     
    +    def test_resume_failed_task_and_successful_task(self, workflow_context, thread_executor):
    --- End diff --
    
    Add one more test which runs a workflow (`retry_failed` = `False`) where the first task fails, the second one depends on the first one, and on resume validate that the first task doesn't run again but the second one does and succeeds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---