You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/25 22:29:39 UTC
Review Request 61919: Adjusted the test helpers for creating host and
sandbox path volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61919/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Joseph Wu.
Bugs: MESOS-7306
https://issues.apache.org/jira/browse/MESOS-7306
Repository: mesos
Description
-------
Previously, we used the same helper for creating both host and sandbox
path volumes. This patch split that into two separate helpers.
Diffs
-----
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 77131870ccfec0ec426962e56dc4f2cd35433946
src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION
src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e
Diff: https://reviews.apache.org/r/61919/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 61919: Adjusted the test helpers for creating host
and sandbox path volumes.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61919/#review183997
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 25, 2017, 3:29 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61919/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2017, 3:29 p.m.)
>
>
> Review request for mesos, Gilbert Song and Joseph Wu.
>
>
> Bugs: MESOS-7306
> https://issues.apache.org/jira/browse/MESOS-7306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we used the same helper for creating both host and sandbox
> path volumes. This patch split that into two separate helpers.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 77131870ccfec0ec426962e56dc4f2cd35433946
> src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION
> src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e
>
>
> Diff: https://reviews.apache.org/r/61919/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>