You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2012/10/30 20:02:13 UTC
[jira] [Created] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Jean-Daniel Cryans created HBASE-7073:
-----------------------------------------
Summary: OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
Key: HBASE-7073
URL: https://issues.apache.org/jira/browse/HBASE-7073
Project: HBase
Issue Type: Improvement
Affects Versions: 0.94.2
Reporter: Jean-Daniel Cryans
Assignee: Elliott Clark
Priority: Minor
Fix For: 0.94.4
Trying some increments on my local machine I was surprised to see this in my jstacks:
{noformat}
java.lang.Thread.State: RUNNABLE
at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
- locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
{noformat}
It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7073:
---------------------------------
Status: Patch Available (was: Open)
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.4
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487224#comment-13487224 ]
Hadoop QA commented on HBASE-7073:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551417/HBASE-7073-0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3184//console
This message is automatically generated.
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.4
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487220#comment-13487220 ]
Jean-Daniel Cryans commented on HBASE-7073:
-------------------------------------------
+1, I was about to moan about defaulting {{exposeTimes}} to false while it's true right now in doSafeIncTimeVarying but we don't even check if {{conf}} is null in there so it's a moot point.
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.4
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7073:
---------------------------------
Attachment: HBASE-7073-0.patch
Here's a patch for 0.94. It just makes all of the private variables final, and adds a final boolean.
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.4
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487540#comment-13487540 ]
Lars Hofhansl commented on HBASE-7073:
--------------------------------------
nice
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.3
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7073:
---------------------------------
Fix Version/s: (was: 0.94.4)
0.94.3
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.3
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-7073:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.94 in revision 1403865.
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.4
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487503#comment-13487503 ]
Hudson commented on HBASE-7073:
-------------------------------
Integrated in HBase-0.94 #561 (See [https://builds.apache.org/job/HBase-0.94/561/])
HBASE-7073 OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes (Revision 1403865)
Result = SUCCESS
eclark :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.3
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7073) OperationMetrics needs to cache the
value of hbase.metrics.exposeOperationTimes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490391#comment-13490391 ]
Hudson commented on HBASE-7073:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
HBASE-7073 OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes (Revision 1403865)
Result = FAILURE
eclark :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java
> OperationMetrics needs to cache the value of hbase.metrics.exposeOperationTimes
> -------------------------------------------------------------------------------
>
> Key: HBASE-7073
> URL: https://issues.apache.org/jira/browse/HBASE-7073
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.2
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Priority: Minor
> Fix For: 0.94.3
>
> Attachments: HBASE-7073-0.patch
>
>
> Trying some increments on my local machine I was surprised to see this in my jstacks:
> {noformat}
> java.lang.Thread.State: RUNNABLE
> at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
> - locked <7c4a26430> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration$1.get(CompoundConfiguration.java:94)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.get(CompoundConfiguration.java:186)
> at org.apache.hadoop.hbase.regionserver.CompoundConfiguration.getBoolean(CompoundConfiguration.java:318)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doSafeIncTimeVarying(OperationMetrics.java:217)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.doUpdateTimeVarying(OperationMetrics.java:212)
> at org.apache.hadoop.hbase.regionserver.metrics.OperationMetrics.updateIncrementMetrics(OperationMetrics.java:133)
> at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:4817)
> {noformat}
> It's a pretty horrible lookup that's inline with everything else in that class and there's no reason why it shouldn't be a final boolean.
> Assigning this to the master of metrics since he asked for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira