You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/04/04 13:51:42 UTC
[GitHub] [orc] guiyanakuang opened a new pull request, #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
guiyanakuang opened a new pull request, #1077:
URL: https://github.com/apache/orc/pull/1077
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
This pr is aimed at checking whether the float category statistic sum has a finite value.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When the orc float category is written with NaN, pushing down is not supported.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1077:
URL: https://github.com/apache/orc/pull/1077#issuecomment-1087819831
Hi, @guiyanakuang .
- Could you make a backporting patch to branch-1.7, please?
- This works in `main` branch but not in `branch-1.7`. We need to pass CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1077:
URL: https://github.com/apache/orc/pull/1077#issuecomment-1087834344
I deleted my previous comment about the branch-1.7 test result.
At a clean build, I verified this patch in branch-1.7 and backported. Thank you again, @guiyanakuang .
Could you re-run your integration tests, @williamhyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1077:
URL: https://github.com/apache/orc/pull/1077#issuecomment-1088196218
Thanks @dongjoon-hyun . I checked the branch-1.6 and confirmed it has the same problem. This pr can just cherry pick and fix it without any conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1077:
URL: https://github.com/apache/orc/pull/1077#issuecomment-1087846051
BTW, @guiyanakuang . Could you check branch-1.6 too when you have a time? We backported the following in branch-1.6. I guess we might have the same issue there.
- https://github.com/apache/orc/pull/1055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1077:
URL: https://github.com/apache/orc/pull/1077#issuecomment-1088207106
Thank you, @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1077: ORC-1146: Float category missing check if the statistic sum is a finite value
URL: https://github.com/apache/orc/pull/1077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org