(solr) branch branch_9x updated: Correct the log.error to include the file name instead of hard-coded … (#2186)

[us...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

uschindler pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/branch_9x by this push:
     new ecbdc57d4d1 Correct the log.error to include the file name instead of hard-coded … (#2186)
ecbdc57d4d1 is described below

commit ecbdc57d4d138e462a1ffac41823944f408926f2
Author: Hamzeh Aldmour <42...@users.noreply.github.com>
AuthorDate: Tue Jan 9 23:05:33 2024 +0300

    Correct the log.error to include the file name instead of hard-coded … (#2186)
    
    * Correct the log.error to include the file name instead of hard-coded value
    
    * Add entry in the CHANGES.txt file in the 9.5 section
    
    * Update CHANGES.txt
---
 solr/CHANGES.txt                                                       | 2 ++
 .../core/src/java/org/apache/solr/search/function/FileFloatSource.java | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 95c0bf7c774..54692eff5d3 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -65,6 +65,8 @@ Improvements
 * SOLR-16397: The MERGEINDEXES v2 endpoint has been updated to be more REST-ful.
   MERGEINDEXES is now available at `POST /api/cores/coreName/merge-indices` (Sanjay Dutt via Jason Gerlowski)
 
+* PR#2186: Include the external file name in the log instead of the hard-coded value in FileFloatSource.java. (Hamzeh Aldmour via Uwe Schindler)
+
 Optimizations
 ---------------------
 * SOLR-17084: LBSolrClient (used by CloudSolrClient) now returns the count of core tracked as not live AKA zombies
diff --git a/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java b/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java
index b7628fde606..7664a822bcb 100644
--- a/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java
+++ b/solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java
@@ -307,7 +307,8 @@ public class FileFloatSource extends ValueSource {
         } catch (Exception e) {
           if (++otherErrors <= 10) {
             log.error(
-                "Error loading external value source + fileName + {}{}",
+                "Error loading external value source: {} {}{}",
+                fname,
                 e,
                 (otherErrors < 10 ? "" : "\tSkipping future errors for this file."));
           }