[GitHub] [tomcat-maven-plugin] markt-asf commented on a change in pull request #32: support tomcat 8.5

[GitBox <gi...@apache.org>]

markt-asf commented on a change in pull request #32:
URL: https://github.com/apache/tomcat-maven-plugin/pull/32#discussion_r458305303



##########
File path: tomcat8-maven-plugin/pom.xml
##########
@@ -137,12 +137,12 @@
     <dependency>
       <groupId>org.apache.tomcat.embed</groupId>
       <artifactId>tomcat-embed-logging-juli</artifactId>
-      <version>${tomcat8Version}</version>
+      <version>${tomcat8LoggingVersion}</version>
     </dependency>
     <dependency>
       <groupId>org.apache.tomcat.embed</groupId>
       <artifactId>tomcat-embed-logging-log4j</artifactId>
-      <version>${tomcat8Version}</version>
+      <version>${tomcat8LoggingVersion}</version>
     </dependency>
 

Review comment:
       These dependencies should be removed. They are no longer used in 8.5.x




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org