You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/31 19:47:02 UTC
[GitHub] [incubator-pinot] mayankshriv opened a new pull request #5785: Add missing null check before closing reader context.
mayankshriv opened a new pull request #5785:
URL: https://github.com/apache/incubator-pinot/pull/5785
With lazy initialization, the ForwardIndexReaderContext can be null. The close()
method is not called today, but if/when it will be, this could lead to NPE.
- Adding NULL check to fix this potential problem.
- Also, assigned getContext() to local variable for readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv merged pull request #5785: Add missing null check before closing reader context.
Posted by GitBox <gi...@apache.org>.
mayankshriv merged pull request #5785:
URL: https://github.com/apache/incubator-pinot/pull/5785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org