You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Tom hobbs <tv...@googlemail.com> on 2009/04/30 01:15:30 UTC
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./
sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Great, I'm glad it works. (Phew).
Sorry about the code header, I knew about it but just forgot to add it in
all my excitement.
As you can probably see by now, I've just applied a patch and supplied a
unit test. With the unit test there is now a dependency on;
- JUnit 3
- Easy Mock 2.4
- Easy Mock Class Extensions 2.4
- CGLIB (No Dependencies) 2.2
What is the best way (or should I even do it?) of getting these JARs
committed/uploaded so the build scripts can use them?
As far as I'm concerned I have no particular version preference of the
above dependencies, those just happened to be the ones I already had
downloaded. I'm having to change the code to suit other versions as
people see fit.
Cheers,
Tom
On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting
<ju...@gmail.com> wrote:
> Hi,
>
> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>> Log:
>> Placeholder for unit test for River-283.
>> Also trying to validate I have my SVNKit setup properly in eclipse.
>
> Seems to work fine, including the correct svn:eol-style setting.
>
> One comment though...
>
>> ---
>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>> (added)
>> +++
>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>> Wed Apr 29 19:59:44 2009
>> @@ -0,0 +1,16 @@
>> +package com.sun.jini.outrigger;
>> +[...]
>
> All our source files should start with the following Apache license
> header:
>
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
>
> See http://www.apache.org/legal/src-headers.html for more background.
>
> BR,
>
> Jukka Zitting
--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./
sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Tom hobbs <tv...@googlemail.com>.
I've made the directory structure suggested by Jonathan and have added the
JUnit 4 (plus other dependencies) and this MTC jar as well (hopefully I
used the right version).
Let me know if anything else is missing. I tried using SVN move to move
the unit test I wrote the other day, but that seemed to fail spectacularly
on my machine and that's what prompted the other additions/removes etc.
Whilst writing this email I've remembered that I was supposed to use
Mockito not EasyMock, so I'll make that change next. Sorry.
Tom
On Thu, 30 Apr 2009 21:48:26 -0000, Peter Firmstone <ji...@zeus.net.au>
wrote:
> In that case then, lets do it.
>
> While were at it can we include MTC also, this will make it possible for
> me to test the synchronised code in the classdepend package. I was
> going to wait until after AR2, but can't see any real reason not to do
> it now.
>
> http://www.cs.umd.edu/projects/PL/multithreadedtc/
>
> Cheers,
>
> Peter.
>
> Jeff Ramsdale wrote:
>> Correction: JUnit 4 doesn't require annotations, it allows them. The old
>> syntax still works.
>> -jeff
>>
>> On Wed, Apr 29, 2009 at 7:57 PM, Peter Firmstone <ji...@zeus.net.au>
>> wrote:
>>
>>
>>> I haven't got any objections to using JUnit 4. How about we wait until
>>> after AR2 however as it requires @annotations ;)
>>>
>>> Peter.
>>>
>>>
>>> Jeff Ramsdale wrote:
>>>
>>>
>>>> I think there was a question raised about JUnit 3 vs. 4. Could we go
>>>> with
>>>> 4?
>>>> 3 was released a LONG time ago and the old syntax still works in 4 so
>>>> it
>>>> shouldn't be a big issue. We've already agreed to switch to Java 5 so
>>>> that
>>>> isn't an impediment.
>>>> -jeff
>>>>
>>>> On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com>
>>>> wrote:
>>>>
>>>>
>>>>
>>>>
>>>>> Great, I'm glad it works. (Phew).
>>>>>
>>>>> Sorry about the code header, I knew about it but just forgot to add
>>>>> it in
>>>>> all my excitement.
>>>>>
>>>>> As you can probably see by now, I've just applied a patch and
>>>>> supplied a
>>>>> unit test. With the unit test there is now a dependency on;
>>>>>
>>>>> - JUnit 3
>>>>> - Easy Mock 2.4
>>>>> - Easy Mock Class Extensions 2.4
>>>>> - CGLIB (No Dependencies) 2.2
>>>>>
>>>>> What is the best way (or should I even do it?) of getting these JARs
>>>>> committed/uploaded so the build scripts can use them?
>>>>>
>>>>> As far as I'm concerned I have no particular version preference of
>>>>> the
>>>>> above dependencies, those just happened to be the ones I already had
>>>>> downloaded. I'm having to change the code to suit other versions as
>>>>> people
>>>>> see fit.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Tom
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <
>>>>> jukka.zitting@gmail.com>
>>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>>
>>>>>
>>>>>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Log:
>>>>>>> Placeholder for unit test for River-283.
>>>>>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Seems to work fine, including the correct svn:eol-style setting.
>>>>>>
>>>>>> One comment though...
>>>>>>
>>>>>> ---
>>>>>>
>>>>>>
>>>>>>
>>>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>>>> (added)
>>>>>>> +++
>>>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>>>> Wed
>>>>>>> Apr 29 19:59:44 2009
>>>>>>> @@ -0,0 +1,16 @@
>>>>>>> +package com.sun.jini.outrigger;
>>>>>>> +[...]
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> All our source files should start with the following Apache license
>>>>>> header:
>>>>>>
>>>>>> /*
>>>>>> * Licensed to the Apache Software Foundation (ASF) under one
>>>>>> * or more contributor license agreements. See the NOTICE file
>>>>>> * distributed with this work for additional information
>>>>>> * regarding copyright ownership. The ASF licenses this file
>>>>>> * to you under the Apache License, Version 2.0 (the
>>>>>> * "License"); you may not use this file except in compliance
>>>>>> * with the License. You may obtain a copy of the License at
>>>>>> *
>>>>>> * http://www.apache.org/licenses/LICENSE-2.0
>>>>>> *
>>>>>> * Unless required by applicable law or agreed to in writing,
>>>>>> software
>>>>>> * distributed under the License is distributed on an "AS IS" BASIS,
>>>>>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>>>> implied.
>>>>>> * See the License for the specific language governing permissions
>>>>>> and
>>>>>> * limitations under the License.
>>>>>> */
>>>>>>
>>>>>> See http://www.apache.org/legal/src-headers.html for more
>>>>>> background.
>>>>>>
>>>>>> BR,
>>>>>>
>>>>>> Jukka Zitting
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> --
>>>>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>
--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com:
./ sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Peter Firmstone <ji...@zeus.net.au>.
In that case then, lets do it.
While were at it can we include MTC also, this will make it possible for
me to test the synchronised code in the classdepend package. I was
going to wait until after AR2, but can't see any real reason not to do
it now.
http://www.cs.umd.edu/projects/PL/multithreadedtc/
Cheers,
Peter.
Jeff Ramsdale wrote:
> Correction: JUnit 4 doesn't require annotations, it allows them. The old
> syntax still works.
> -jeff
>
> On Wed, Apr 29, 2009 at 7:57 PM, Peter Firmstone <ji...@zeus.net.au> wrote:
>
>
>> I haven't got any objections to using JUnit 4. How about we wait until
>> after AR2 however as it requires @annotations ;)
>>
>> Peter.
>>
>>
>> Jeff Ramsdale wrote:
>>
>>
>>> I think there was a question raised about JUnit 3 vs. 4. Could we go with
>>> 4?
>>> 3 was released a LONG time ago and the old syntax still works in 4 so it
>>> shouldn't be a big issue. We've already agreed to switch to Java 5 so that
>>> isn't an impediment.
>>> -jeff
>>>
>>> On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com>
>>> wrote:
>>>
>>>
>>>
>>>
>>>> Great, I'm glad it works. (Phew).
>>>>
>>>> Sorry about the code header, I knew about it but just forgot to add it in
>>>> all my excitement.
>>>>
>>>> As you can probably see by now, I've just applied a patch and supplied a
>>>> unit test. With the unit test there is now a dependency on;
>>>>
>>>> - JUnit 3
>>>> - Easy Mock 2.4
>>>> - Easy Mock Class Extensions 2.4
>>>> - CGLIB (No Dependencies) 2.2
>>>>
>>>> What is the best way (or should I even do it?) of getting these JARs
>>>> committed/uploaded so the build scripts can use them?
>>>>
>>>> As far as I'm concerned I have no particular version preference of the
>>>> above dependencies, those just happened to be the ones I already had
>>>> downloaded. I'm having to change the code to suit other versions as
>>>> people
>>>> see fit.
>>>>
>>>> Cheers,
>>>>
>>>> Tom
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <
>>>> jukka.zitting@gmail.com>
>>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>>
>>>>
>>>>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> Log:
>>>>>> Placeholder for unit test for River-283.
>>>>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> Seems to work fine, including the correct svn:eol-style setting.
>>>>>
>>>>> One comment though...
>>>>>
>>>>> ---
>>>>>
>>>>>
>>>>>
>>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>>> (added)
>>>>>> +++
>>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>>> Wed
>>>>>> Apr 29 19:59:44 2009
>>>>>> @@ -0,0 +1,16 @@
>>>>>> +package com.sun.jini.outrigger;
>>>>>> +[...]
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> All our source files should start with the following Apache license
>>>>> header:
>>>>>
>>>>> /*
>>>>> * Licensed to the Apache Software Foundation (ASF) under one
>>>>> * or more contributor license agreements. See the NOTICE file
>>>>> * distributed with this work for additional information
>>>>> * regarding copyright ownership. The ASF licenses this file
>>>>> * to you under the Apache License, Version 2.0 (the
>>>>> * "License"); you may not use this file except in compliance
>>>>> * with the License. You may obtain a copy of the License at
>>>>> *
>>>>> * http://www.apache.org/licenses/LICENSE-2.0
>>>>> *
>>>>> * Unless required by applicable law or agreed to in writing, software
>>>>> * distributed under the License is distributed on an "AS IS" BASIS,
>>>>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>>> implied.
>>>>> * See the License for the specific language governing permissions and
>>>>> * limitations under the License.
>>>>> */
>>>>>
>>>>> See http://www.apache.org/legal/src-headers.html for more background.
>>>>>
>>>>> BR,
>>>>>
>>>>> Jukka Zitting
>>>>>
>>>>>
>>>>>
>>>>>
>>>> --
>>>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>
>
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./
sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Jeff Ramsdale <je...@gmail.com>.
Correction: JUnit 4 doesn't require annotations, it allows them. The old
syntax still works.
-jeff
On Wed, Apr 29, 2009 at 7:57 PM, Peter Firmstone <ji...@zeus.net.au> wrote:
> I haven't got any objections to using JUnit 4. How about we wait until
> after AR2 however as it requires @annotations ;)
>
> Peter.
>
>
> Jeff Ramsdale wrote:
>
>> I think there was a question raised about JUnit 3 vs. 4. Could we go with
>> 4?
>> 3 was released a LONG time ago and the old syntax still works in 4 so it
>> shouldn't be a big issue. We've already agreed to switch to Java 5 so that
>> isn't an impediment.
>> -jeff
>>
>> On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com>
>> wrote:
>>
>>
>>
>>> Great, I'm glad it works. (Phew).
>>>
>>> Sorry about the code header, I knew about it but just forgot to add it in
>>> all my excitement.
>>>
>>> As you can probably see by now, I've just applied a patch and supplied a
>>> unit test. With the unit test there is now a dependency on;
>>>
>>> - JUnit 3
>>> - Easy Mock 2.4
>>> - Easy Mock Class Extensions 2.4
>>> - CGLIB (No Dependencies) 2.2
>>>
>>> What is the best way (or should I even do it?) of getting these JARs
>>> committed/uploaded so the build scripts can use them?
>>>
>>> As far as I'm concerned I have no particular version preference of the
>>> above dependencies, those just happened to be the ones I already had
>>> downloaded. I'm having to change the code to suit other versions as
>>> people
>>> see fit.
>>>
>>> Cheers,
>>>
>>> Tom
>>>
>>>
>>>
>>>
>>> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <
>>> jukka.zitting@gmail.com>
>>> wrote:
>>>
>>> Hi,
>>>
>>>
>>>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>>>
>>>>
>>>>
>>>>> Log:
>>>>> Placeholder for unit test for River-283.
>>>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>>>
>>>>>
>>>>>
>>>> Seems to work fine, including the correct svn:eol-style setting.
>>>>
>>>> One comment though...
>>>>
>>>> ---
>>>>
>>>>
>>>>>
>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>> (added)
>>>>> +++
>>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>>> Wed
>>>>> Apr 29 19:59:44 2009
>>>>> @@ -0,0 +1,16 @@
>>>>> +package com.sun.jini.outrigger;
>>>>> +[...]
>>>>>
>>>>>
>>>>>
>>>> All our source files should start with the following Apache license
>>>> header:
>>>>
>>>> /*
>>>> * Licensed to the Apache Software Foundation (ASF) under one
>>>> * or more contributor license agreements. See the NOTICE file
>>>> * distributed with this work for additional information
>>>> * regarding copyright ownership. The ASF licenses this file
>>>> * to you under the Apache License, Version 2.0 (the
>>>> * "License"); you may not use this file except in compliance
>>>> * with the License. You may obtain a copy of the License at
>>>> *
>>>> * http://www.apache.org/licenses/LICENSE-2.0
>>>> *
>>>> * Unless required by applicable law or agreed to in writing, software
>>>> * distributed under the License is distributed on an "AS IS" BASIS,
>>>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>> implied.
>>>> * See the License for the specific language governing permissions and
>>>> * limitations under the License.
>>>> */
>>>>
>>>> See http://www.apache.org/legal/src-headers.html for more background.
>>>>
>>>> BR,
>>>>
>>>> Jukka Zitting
>>>>
>>>>
>>>>
>>>
>>> --
>>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>>>
>>>
>>>
>>
>>
>>
>
>
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./
sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Jonathan Costers <jo...@googlemail.com>.
What about this:
test/
test/src <put test code here>
test/lib <put test lib dependencies here>
test/classes <put compiled tests here>
test/conf <put test config here>
?
Pretty standard layout.
2009/4/30 Tom Hobbs <to...@sucfin.com>
> Junit 4 works for me and I'm happy to change yesterday's commit to using
> that version.
>
> My question still remains though; what is the process and where should I
> put, the JARs necessary to support the unit test?
>
> Cheers,
>
> Tom
>
> -----Original Message-----
> From: Peter Firmstone [mailto:jini@zeus.net.au]
> Sent: 30 April 2009 03:58
> To: river-dev@incubator.apache.org
> Subject: Re: svn commit: r769903 - in
> /incubator/river/jtsk/trunk/test/com: ./ sun/ sun/jini/
> sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
>
> I haven't got any objections to using JUnit 4. How about we wait until
> after AR2 however as it requires @annotations ;)
>
> Peter.
>
> Jeff Ramsdale wrote:
> > I think there was a question raised about JUnit 3 vs. 4. Could we go
> with 4?
> > 3 was released a LONG time ago and the old syntax still works in 4 so
> it
> > shouldn't be a big issue. We've already agreed to switch to Java 5 so
> that
> > isn't an impediment.
> > -jeff
> >
> > On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com>
> wrote:
> >
> >
> >> Great, I'm glad it works. (Phew).
> >>
> >> Sorry about the code header, I knew about it but just forgot to add
> it in
> >> all my excitement.
> >>
> >> As you can probably see by now, I've just applied a patch and
> supplied a
> >> unit test. With the unit test there is now a dependency on;
> >>
> >> - JUnit 3
> >> - Easy Mock 2.4
> >> - Easy Mock Class Extensions 2.4
> >> - CGLIB (No Dependencies) 2.2
> >>
> >> What is the best way (or should I even do it?) of getting these JARs
> >> committed/uploaded so the build scripts can use them?
> >>
> >> As far as I'm concerned I have no particular version preference of
> the
> >> above dependencies, those just happened to be the ones I already had
> >> downloaded. I'm having to change the code to suit other versions as
> people
> >> see fit.
> >>
> >> Cheers,
> >>
> >> Tom
> >>
> >>
> >>
> >>
> >> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting
> <ju...@gmail.com>
> >> wrote:
> >>
> >> Hi,
> >>
> >>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
> >>>
> >>>
> >>>> Log:
> >>>> Placeholder for unit test for River-283.
> >>>> Also trying to validate I have my SVNKit setup properly in eclipse.
> >>>>
> >>>>
> >>> Seems to work fine, including the correct svn:eol-style setting.
> >>>
> >>> One comment though...
> >>>
> >>> ---
> >>>
> >>>>
> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
> >>>> (added)
> >>>> +++
> >>>>
> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
> Wed
> >>>> Apr 29 19:59:44 2009
> >>>> @@ -0,0 +1,16 @@
> >>>> +package com.sun.jini.outrigger;
> >>>> +[...]
> >>>>
> >>>>
> >>> All our source files should start with the following Apache license
> >>> header:
> >>>
> >>> /*
> >>> * Licensed to the Apache Software Foundation (ASF) under one
> >>> * or more contributor license agreements. See the NOTICE file
> >>> * distributed with this work for additional information
> >>> * regarding copyright ownership. The ASF licenses this file
> >>> * to you under the Apache License, Version 2.0 (the
> >>> * "License"); you may not use this file except in compliance
> >>> * with the License. You may obtain a copy of the License at
> >>> *
> >>> * http://www.apache.org/licenses/LICENSE-2.0
> >>> *
> >>> * Unless required by applicable law or agreed to in writing,
> software
> >>> * distributed under the License is distributed on an "AS IS" BASIS,
> >>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >>> implied.
> >>> * See the License for the specific language governing permissions
> and
> >>> * limitations under the License.
> >>> */
> >>>
> >>> See http://www.apache.org/legal/src-headers.html for more
> background.
> >>>
> >>> BR,
> >>>
> >>> Jukka Zitting
> >>>
> >>>
> >>
> >> --
> >> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
> >>
> >>
> >
> >
>
> www.sucdenfinancial.com
>
> Sucden Financial Limited, Plantation Place South, 60 Great Tower Street,
> London EC3R 5AZ
> Telephone +44 203 207 5000
>
> Registered in England no. 1095841
> VAT registration no. GB 446 9061 33
>
> Authorised and Regulated by the Financial Services Authority (FSA) and
> entered in the FSA register under no. 114239
>
> This email, including any files transmitted with it, is confidential and
> may be privileged. It may be read, copied and used only by the intended
> recipient. If you are not the intended recipient of this message, please
> notify postmaster@sucfin.com immediately and delete it from your computer
> system.
>
> We believe, but do not warrant, that this email and its attachments are
> virus-free, but you should check.
>
> Sucden Financial Limited may monitor traffic data of both business and
> personal emails. By replying to this email, you consent to Sucden Financial
> 's monitoring the content of any emails you send to or receive from Sucden
> Financial . Sucden Financial is not liable for any opinions expressed by the
> sender where this is a non-business email.
>
> The contents of this e-mail do not constitute advice and should not be
> regarded as a recommendation to buy, sell or otherwise deal with any
> particular investment.
>
> This message has been scanned for viruses by Mimecast.
RE: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./ sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Tom Hobbs <to...@sucfin.com>.
Junit 4 works for me and I'm happy to change yesterday's commit to using
that version.
My question still remains though; what is the process and where should I
put, the JARs necessary to support the unit test?
Cheers,
Tom
-----Original Message-----
From: Peter Firmstone [mailto:jini@zeus.net.au]
Sent: 30 April 2009 03:58
To: river-dev@incubator.apache.org
Subject: Re: svn commit: r769903 - in
/incubator/river/jtsk/trunk/test/com: ./ sun/ sun/jini/
sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
I haven't got any objections to using JUnit 4. How about we wait until
after AR2 however as it requires @annotations ;)
Peter.
Jeff Ramsdale wrote:
> I think there was a question raised about JUnit 3 vs. 4. Could we go
with 4?
> 3 was released a LONG time ago and the old syntax still works in 4 so
it
> shouldn't be a big issue. We've already agreed to switch to Java 5 so
that
> isn't an impediment.
> -jeff
>
> On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com>
wrote:
>
>
>> Great, I'm glad it works. (Phew).
>>
>> Sorry about the code header, I knew about it but just forgot to add
it in
>> all my excitement.
>>
>> As you can probably see by now, I've just applied a patch and
supplied a
>> unit test. With the unit test there is now a dependency on;
>>
>> - JUnit 3
>> - Easy Mock 2.4
>> - Easy Mock Class Extensions 2.4
>> - CGLIB (No Dependencies) 2.2
>>
>> What is the best way (or should I even do it?) of getting these JARs
>> committed/uploaded so the build scripts can use them?
>>
>> As far as I'm concerned I have no particular version preference of
the
>> above dependencies, those just happened to be the ones I already had
>> downloaded. I'm having to change the code to suit other versions as
people
>> see fit.
>>
>> Cheers,
>>
>> Tom
>>
>>
>>
>>
>> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting
<ju...@gmail.com>
>> wrote:
>>
>> Hi,
>>
>>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>>
>>>
>>>> Log:
>>>> Placeholder for unit test for River-283.
>>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>>
>>>>
>>> Seems to work fine, including the correct svn:eol-style setting.
>>>
>>> One comment though...
>>>
>>> ---
>>>
>>>>
incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>> (added)
>>>> +++
>>>>
incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
Wed
>>>> Apr 29 19:59:44 2009
>>>> @@ -0,0 +1,16 @@
>>>> +package com.sun.jini.outrigger;
>>>> +[...]
>>>>
>>>>
>>> All our source files should start with the following Apache license
>>> header:
>>>
>>> /*
>>> * Licensed to the Apache Software Foundation (ASF) under one
>>> * or more contributor license agreements. See the NOTICE file
>>> * distributed with this work for additional information
>>> * regarding copyright ownership. The ASF licenses this file
>>> * to you under the Apache License, Version 2.0 (the
>>> * "License"); you may not use this file except in compliance
>>> * with the License. You may obtain a copy of the License at
>>> *
>>> * http://www.apache.org/licenses/LICENSE-2.0
>>> *
>>> * Unless required by applicable law or agreed to in writing,
software
>>> * distributed under the License is distributed on an "AS IS" BASIS,
>>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>> implied.
>>> * See the License for the specific language governing permissions
and
>>> * limitations under the License.
>>> */
>>>
>>> See http://www.apache.org/legal/src-headers.html for more
background.
>>>
>>> BR,
>>>
>>> Jukka Zitting
>>>
>>>
>>
>> --
>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>>
>>
>
>
www.sucdenfinancial.com
Sucden Financial Limited, Plantation Place South, 60 Great Tower Street, London EC3R 5AZ
Telephone +44 203 207 5000
Registered in England no. 1095841
VAT registration no. GB 446 9061 33
Authorised and Regulated by the Financial Services Authority (FSA) and entered in the FSA register under no. 114239
This email, including any files transmitted with it, is confidential and may be privileged. It may be read, copied and used only by the intended recipient. If you are not the intended recipient of this message, please notify postmaster@sucfin.com immediately and delete it from your computer system.
We believe, but do not warrant, that this email and its attachments are virus-free, but you should check.
Sucden Financial Limited may monitor traffic data of both business and personal emails. By replying to this email, you consent to Sucden Financial 's monitoring the content of any emails you send to or receive from Sucden Financial . Sucden Financial is not liable for any opinions expressed by the sender where this is a non-business email.
The contents of this e-mail do not constitute advice and should not be regarded as a recommendation to buy, sell or otherwise deal with any particular investment.
This message has been scanned for viruses by Mimecast.
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com:
./ sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Peter Firmstone <ji...@zeus.net.au>.
I haven't got any objections to using JUnit 4. How about we wait until
after AR2 however as it requires @annotations ;)
Peter.
Jeff Ramsdale wrote:
> I think there was a question raised about JUnit 3 vs. 4. Could we go with 4?
> 3 was released a LONG time ago and the old syntax still works in 4 so it
> shouldn't be a big issue. We've already agreed to switch to Java 5 so that
> isn't an impediment.
> -jeff
>
> On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com> wrote:
>
>
>> Great, I'm glad it works. (Phew).
>>
>> Sorry about the code header, I knew about it but just forgot to add it in
>> all my excitement.
>>
>> As you can probably see by now, I've just applied a patch and supplied a
>> unit test. With the unit test there is now a dependency on;
>>
>> - JUnit 3
>> - Easy Mock 2.4
>> - Easy Mock Class Extensions 2.4
>> - CGLIB (No Dependencies) 2.2
>>
>> What is the best way (or should I even do it?) of getting these JARs
>> committed/uploaded so the build scripts can use them?
>>
>> As far as I'm concerned I have no particular version preference of the
>> above dependencies, those just happened to be the ones I already had
>> downloaded. I'm having to change the code to suit other versions as people
>> see fit.
>>
>> Cheers,
>>
>> Tom
>>
>>
>>
>>
>> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <ju...@gmail.com>
>> wrote:
>>
>> Hi,
>>
>>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>>
>>>
>>>> Log:
>>>> Placeholder for unit test for River-283.
>>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>>
>>>>
>>> Seems to work fine, including the correct svn:eol-style setting.
>>>
>>> One comment though...
>>>
>>> ---
>>>
>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>>> (added)
>>>> +++
>>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java Wed
>>>> Apr 29 19:59:44 2009
>>>> @@ -0,0 +1,16 @@
>>>> +package com.sun.jini.outrigger;
>>>> +[...]
>>>>
>>>>
>>> All our source files should start with the following Apache license
>>> header:
>>>
>>> /*
>>> * Licensed to the Apache Software Foundation (ASF) under one
>>> * or more contributor license agreements. See the NOTICE file
>>> * distributed with this work for additional information
>>> * regarding copyright ownership. The ASF licenses this file
>>> * to you under the Apache License, Version 2.0 (the
>>> * "License"); you may not use this file except in compliance
>>> * with the License. You may obtain a copy of the License at
>>> *
>>> * http://www.apache.org/licenses/LICENSE-2.0
>>> *
>>> * Unless required by applicable law or agreed to in writing, software
>>> * distributed under the License is distributed on an "AS IS" BASIS,
>>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>> implied.
>>> * See the License for the specific language governing permissions and
>>> * limitations under the License.
>>> */
>>>
>>> See http://www.apache.org/legal/src-headers.html for more background.
>>>
>>> BR,
>>>
>>> Jukka Zitting
>>>
>>>
>>
>> --
>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>>
>>
>
>
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com: ./
sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Jeff Ramsdale <je...@gmail.com>.
I think there was a question raised about JUnit 3 vs. 4. Could we go with 4?
3 was released a LONG time ago and the old syntax still works in 4 so it
shouldn't be a big issue. We've already agreed to switch to Java 5 so that
isn't an impediment.
-jeff
On Wed, Apr 29, 2009 at 4:15 PM, Tom hobbs <tv...@googlemail.com> wrote:
> Great, I'm glad it works. (Phew).
>
> Sorry about the code header, I knew about it but just forgot to add it in
> all my excitement.
>
> As you can probably see by now, I've just applied a patch and supplied a
> unit test. With the unit test there is now a dependency on;
>
> - JUnit 3
> - Easy Mock 2.4
> - Easy Mock Class Extensions 2.4
> - CGLIB (No Dependencies) 2.2
>
> What is the best way (or should I even do it?) of getting these JARs
> committed/uploaded so the build scripts can use them?
>
> As far as I'm concerned I have no particular version preference of the
> above dependencies, those just happened to be the ones I already had
> downloaded. I'm having to change the code to suit other versions as people
> see fit.
>
> Cheers,
>
> Tom
>
>
>
>
> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting <ju...@gmail.com>
> wrote:
>
> Hi,
>>
>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>
>>> Log:
>>> Placeholder for unit test for River-283.
>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>>
>>
>> Seems to work fine, including the correct svn:eol-style setting.
>>
>> One comment though...
>>
>> ---
>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>> (added)
>>> +++
>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java Wed
>>> Apr 29 19:59:44 2009
>>> @@ -0,0 +1,16 @@
>>> +package com.sun.jini.outrigger;
>>> +[...]
>>>
>>
>> All our source files should start with the following Apache license
>> header:
>>
>> /*
>> * Licensed to the Apache Software Foundation (ASF) under one
>> * or more contributor license agreements. See the NOTICE file
>> * distributed with this work for additional information
>> * regarding copyright ownership. The ASF licenses this file
>> * to you under the Apache License, Version 2.0 (the
>> * "License"); you may not use this file except in compliance
>> * with the License. You may obtain a copy of the License at
>> *
>> * http://www.apache.org/licenses/LICENSE-2.0
>> *
>> * Unless required by applicable law or agreed to in writing, software
>> * distributed under the License is distributed on an "AS IS" BASIS,
>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> * See the License for the specific language governing permissions and
>> * limitations under the License.
>> */
>>
>> See http://www.apache.org/legal/src-headers.html for more background.
>>
>> BR,
>>
>> Jukka Zitting
>>
>
>
>
> --
> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>
Re: svn commit: r769903 - in /incubator/river/jtsk/trunk/test/com:
./ sun/ sun/jini/ sun/jini/outrigger/ sun/jini/outrigger/TxnTableTest.java
Posted by Peter Firmstone <ji...@zeus.net.au>.
Highlights the benefits of Test driven development doesn't it. The typo
bug wouldn't have ever existed, if the unit test cases were written first.
There probably wouldn't be much benefit in writing a Regression test for
a typo, but unit tests when this type of bug is encountered is most
applicable, the original implementation in this case was obviously never
effectively tested.
Considering there are three types of Testing regimes in River:
Unit Tests
Integration Tests
Regression Tests
Perhaps we should create some guidelines as to where and when such tests
apply? I was thinking of raising the issue on Jira for such a document
to be created. One wouldn't expect concurrency bugs to be discovered in
a Unit test for instance. Command line interfaces also wouldn't be
tested with unit tests.
Your thoughts on recommendations for where, when & why these different
testing regimes apply?
Cheers,
Peter.
Tom hobbs wrote:
> Great, I'm glad it works. (Phew).
>
> Sorry about the code header, I knew about it but just forgot to add it
> in all my excitement.
>
> As you can probably see by now, I've just applied a patch and supplied
> a unit test. With the unit test there is now a dependency on;
>
> - JUnit 3
> - Easy Mock 2.4
> - Easy Mock Class Extensions 2.4
> - CGLIB (No Dependencies) 2.2
>
> What is the best way (or should I even do it?) of getting these JARs
> committed/uploaded so the build scripts can use them?
>
> As far as I'm concerned I have no particular version preference of the
> above dependencies, those just happened to be the ones I already had
> downloaded. I'm having to change the code to suit other versions as
> people see fit.
>
> Cheers,
>
> Tom
>
>
>
> On Wed, 29 Apr 2009 21:06:46 -0000, Jukka Zitting
> <ju...@gmail.com> wrote:
>
>> Hi,
>>
>> On Wed, Apr 29, 2009 at 9:59 PM, <th...@apache.org> wrote:
>>> Log:
>>> Placeholder for unit test for River-283.
>>> Also trying to validate I have my SVNKit setup properly in eclipse.
>>
>> Seems to work fine, including the correct svn:eol-style setting.
>>
>> One comment though...
>>
>>> ---
>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>> (added)
>>> +++
>>> incubator/river/jtsk/trunk/test/com/sun/jini/outrigger/TxnTableTest.java
>>> Wed Apr 29 19:59:44 2009
>>> @@ -0,0 +1,16 @@
>>> +package com.sun.jini.outrigger;
>>> +[...]
>>
>> All our source files should start with the following Apache license
>> header:
>>
>> /*
>> * Licensed to the Apache Software Foundation (ASF) under one
>> * or more contributor license agreements. See the NOTICE file
>> * distributed with this work for additional information
>> * regarding copyright ownership. The ASF licenses this file
>> * to you under the Apache License, Version 2.0 (the
>> * "License"); you may not use this file except in compliance
>> * with the License. You may obtain a copy of the License at
>> *
>> * http://www.apache.org/licenses/LICENSE-2.0
>> *
>> * Unless required by applicable law or agreed to in writing, software
>> * distributed under the License is distributed on an "AS IS" BASIS,
>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> * See the License for the specific language governing permissions and
>> * limitations under the License.
>> */
>>
>> See http://www.apache.org/legal/src-headers.html for more background.
>>
>> BR,
>>
>> Jukka Zitting
>
>
>