You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/25 14:42:03 UTC
[GitHub] [mynewt-nimble] zacwbond opened a new pull request #782: Remove
notification for update process timeout.
zacwbond opened a new pull request #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782
(This addresses issue #780, just like PR #781, which was closed due to some repo juggling on my end.)
From the original
> This is a fix for #780, an issue I submitted earlier today.
>I am connecting as a central to a remote peripheral using a connection interval of 120, latency of 90, and timeout of 3000. Due to the hard-coded 40 second timeout, it is impossible to perform a connection parameter update on this connection. Trying to do so results in a timeout followed by a disconnect 100% of the time.
>My attempt to fix the problem is to compute the timeout based on the current connection parameters instead of just hard-coding a constant value.
Based on @rymanluk's comments to that PR, I have reduced the change to keeping the 40s timeout, but simply not posting an event should a timeout occur.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #782: Remove
notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604525690
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #782:
Remove notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604525690
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #782: Remove
notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604629689
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #782:
Remove notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604091088
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #782: Remove
notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-603895830
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] rymanluk merged pull request #782: Remove
notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
rymanluk merged pull request #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #782:
Remove notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-603895830
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #782: Remove
notification for update process timeout.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #782: Remove notification for update process timeout.
URL: https://github.com/apache/mynewt-nimble/pull/782#issuecomment-604091088
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services