You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/07/15 22:43:18 UTC

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13866


Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................

IMPALA-8758: Improve error message when no executors are online

Prior to this change a dedicated coordinator would not create the
default executor group when registering its own backend descriptor in
the cluster membership. This caused a misleading error message during
scheduling when the default executor group could not be found.

To improve this, we now always create the default executor group and
return an improved error message if it is empty.

This change adds a test that validates that a query against a cluster
without executors returns the expected error.

Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
---
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/scheduler.cc
M bin/start-impala-cluster.py
M tests/custom_cluster/test_coordinators.py
4 files changed, 15 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/13866/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 1:

I'm ok with moving forward with this for now to make the error message more clear, but with IMPALA-8484, the behavior will change altogether and we would queue the query instead. See my comment here: https://gerrit.cloudera.org/#/c/13550/9/be/src/scheduling/admission-controller.cc@1132


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 04:58:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:31:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3883/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:22:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 1:

Note that this change will be obsolete once IMPALA-8484 makes it in, but I'm putting it here in case we want to improve this sooner.


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 22:43:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4604/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 04:58:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 1:

It seems useful to have the test even if the actual code fix is ultimately unneeded.


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:32:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................

IMPALA-8758: Improve error message when no executors are online

Prior to this change a dedicated coordinator would not create the
default executor group when registering its own backend descriptor in
the cluster membership. This caused a misleading error message during
scheduling when the default executor group could not be found.

To improve this, we now always create the default executor group and
return an improved error message if it is empty.

This change adds a test that validates that a query against a cluster
without executors returns the expected error.

Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Reviewed-on: http://gerrit.cloudera.org:8080/13866
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/scheduler.cc
M bin/start-impala-cluster.py
M tests/custom_cluster/test_coordinators.py
4 files changed, 15 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 04:58:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8758: Improve error message when no executors are online

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13866 )

Change subject: IMPALA-8758: Improve error message when no executors are online
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4428ef833363f52b14dfff253569212427a8e2f
Gerrit-Change-Number: 13866
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 11:11:42 +0000
Gerrit-HasComments: No