You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by zj...@apache.org on 2015/05/22 23:41:29 UTC
[11/50] [abbrv] hadoop git commit: HADOOP-11884. test-patch.sh should
pull the real findbugs version (Kengo Seki via aw)
HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/bb44e04a
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/bb44e04a
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/bb44e04a
Branch: refs/heads/YARN-2928
Commit: bb44e04a0d49695b6c2cca38d6ee8238c5ebd4c7
Parents: 01006c9
Author: Allen Wittenauer <aw...@apache.org>
Authored: Mon May 18 16:08:49 2015 +0000
Committer: Zhijie Shen <zj...@apache.org>
Committed: Fri May 22 11:47:02 2015 -0700
----------------------------------------------------------------------
dev-support/test-patch.sh | 5 +++--
hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++
2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/bb44e04a/dev-support/test-patch.sh
----------------------------------------------------------------------
diff --git a/dev-support/test-patch.sh b/dev-support/test-patch.sh
index 9cc5bb0..00a638c 100755
--- a/dev-support/test-patch.sh
+++ b/dev-support/test-patch.sh
@@ -1859,8 +1859,6 @@ function check_findbugs
return 1
fi
- findbugs_version=$("${FINDBUGS_HOME}/bin/findbugs" -version)
-
for module in ${modules}
do
pushd "${module}" >/dev/null
@@ -1872,6 +1870,9 @@ function check_findbugs
popd >/dev/null
done
+ #shellcheck disable=SC2016
+ findbugs_version=$(${AWK} 'match($0, /findbugs-maven-plugin:[^:]*:findbugs/) { print substr($0, RSTART + 22, RLENGTH - 31); exit }' "${PATCH_DIR}/patchFindBugsOutput${module_suffix}.txt")
+
if [[ ${rc} -ne 0 ]]; then
add_jira_table -1 findbugs "The patch appears to cause Findbugs (version ${findbugs_version}) to fail."
return 1
http://git-wip-us.apache.org/repos/asf/hadoop/blob/bb44e04a/hadoop-common-project/hadoop-common/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 2138334..1c2cdaa 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -575,6 +575,9 @@ Release 2.8.0 - UNRELEASED
HADOOP-11939. Deprecate DistCpV1 and Logalyzer.
(Brahma Reddy Battula via aajisaka)
+ HADOOP-11884. test-patch.sh should pull the real findbugs version
+ (Kengo Seki via aw)
+
OPTIMIZATIONS
HADOOP-11785. Reduce the number of listStatus operation in distcp