[GitHub] [spark] MaxGekk commented on a diff in pull request #37357: [SPARK-39933][SQL][TESTS] Check query context by `checkError()`

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #37357:
URL: https://github.com/apache/spark/pull/37357#discussion_r934755593


##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryErrorsSuiteBase.scala:
##########
@@ -51,4 +51,17 @@ trait QueryErrorsSuiteBase extends SharedSparkSession {
     assert(exception.getSqlState === sqlState)
     assert(exception.getMessage === s"""\n[$fullErrorClass] """ + message)
   }
+
+  case class ExpectedContext(

Review Comment:
   For simplicity, `ExpectedContext` contains only import info provided via `QueryContext`. For instance, SQLQueryContext contains entire SQL text NOT fragment. Why should we check entire SQL statements in tests? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org