You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 09:45:44 UTC
Review Request 54655: Renamed LocalNestedContainerObjectApprover for
a more generic name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54655/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Renames `LocalNestedContainerObjectApprover` to
`CombinedACLObjectApprover` in order to allow uses beyond nested
containers.
Diffs
-----
src/authorizer/local/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9
Diff: https://reviews.apache.org/r/54655/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover
for a more generic name.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54655/#review158975
-----------------------------------------------------------
src/authorizer/local/authorizer.cpp (lines 558 - 559)
<https://reviews.apache.org/r/54655/#comment229876>
How did we get from required/optional to framework/executor/command_info? The connection isn't obvious without reading through the code and the callers' code.
src/authorizer/local/authorizer.cpp (lines 582 - 583)
<https://reviews.apache.org/r/54655/#comment229878>
What's optional here? Should there be a `object.has_command_info()` in there somewhere?
- Adam B
On Dec. 12, 2016, 1:51 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54655/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 1:51 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renames `LocalNestedContainerObjectApprover` to
> `CombinedACLObjectApprover` in order to allow uses beyond nested
> containers.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9
>
> Diff: https://reviews.apache.org/r/54655/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover
for a more generic name.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54655/#review167523
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 12, 2016, 9:51 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54655/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 9:51 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renames `LocalNestedContainerObjectApprover` to
> `CombinedACLObjectApprover` in order to allow uses beyond nested
> containers.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9
>
>
> Diff: https://reviews.apache.org/r/54655/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover
for a more generic name.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54655/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 10:51 a.m.)
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Renames `LocalNestedContainerObjectApprover` to
`CombinedACLObjectApprover` in order to allow uses beyond nested
containers.
Diffs
-----
src/authorizer/local/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9
Diff: https://reviews.apache.org/r/54655/diff/
Testing (updated)
-------
make check
Thanks,
Alexander Rojas