You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2013/04/30 20:03:29 UTC
svn commit: r1477744 - /commons/proper/collections/trunk/checkstyle.xml
Author: tn
Date: Tue Apr 30 18:03:28 2013
New Revision: 1477744
URL: http://svn.apache.org/r1477744
Log:
Add trailing whitespace checkstyle rule.
Modified:
commons/proper/collections/trunk/checkstyle.xml
Modified: commons/proper/collections/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/checkstyle.xml?rev=1477744&r1=1477743&r2=1477744&view=diff
==============================================================================
--- commons/proper/collections/trunk/checkstyle.xml (original)
+++ commons/proper/collections/trunk/checkstyle.xml Tue Apr 30 18:03:28 2013
@@ -68,6 +68,13 @@
<!-- Constant names should obey the traditional all uppercase naming convention -->
<module name="ConstantName" />
+ <!-- No trailing whitespace -->
+ <module name="Regexp">
+ <property name="format" value="[ \t]+$"/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="Trailing whitespace"/>
+ </module>
+
<!-- Authors should be in pom.xml file -->
<module name="Regexp">
<property name="format" value="@author"/>
Re: svn commit: r1477744 - /commons/proper/collections/trunk/checkstyle.xml
Posted by sebb <se...@gmail.com>.
On 30 April 2013 19:25, Thomas Neidhart <th...@gmail.com> wrote:
> On 04/30/2013 08:07 PM, sebb wrote:
> > On 30 April 2013 19:03, <tn...@apache.org> wrote:
> >
> >> Author: tn
> >> Date: Tue Apr 30 18:03:28 2013
> >> New Revision: 1477744
> >>
> >> URL: http://svn.apache.org/r1477744
> >> Log:
> >> Add trailing whitespace checkstyle rule.
> >>
> >>
> > That's daring!
> >
> > I've only done the test files so far ...
>
> it's ok, I am working on them, and it's better these things are visible
> so people may have a chance of fixing them, imho.
>
>
Yes, fine, though it will be annoying for a while ...
Maybe consider starting with multiple spaces (e.g. 3+) first?
So long as people fix all the trailing spaces in a single file at once, one
could reduce to 2+ and then 1+.
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1477744 - /commons/proper/collections/trunk/checkstyle.xml
Posted by Thomas Neidhart <th...@gmail.com>.
On 04/30/2013 08:07 PM, sebb wrote:
> On 30 April 2013 19:03, <tn...@apache.org> wrote:
>
>> Author: tn
>> Date: Tue Apr 30 18:03:28 2013
>> New Revision: 1477744
>>
>> URL: http://svn.apache.org/r1477744
>> Log:
>> Add trailing whitespace checkstyle rule.
>>
>>
> That's daring!
>
> I've only done the test files so far ...
it's ok, I am working on them, and it's better these things are visible
so people may have a chance of fixing them, imho.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1477744 - /commons/proper/collections/trunk/checkstyle.xml
Posted by sebb <se...@gmail.com>.
On 30 April 2013 19:03, <tn...@apache.org> wrote:
> Author: tn
> Date: Tue Apr 30 18:03:28 2013
> New Revision: 1477744
>
> URL: http://svn.apache.org/r1477744
> Log:
> Add trailing whitespace checkstyle rule.
>
>
That's daring!
I've only done the test files so far ...
> Modified:
> commons/proper/collections/trunk/checkstyle.xml
>
> Modified: commons/proper/collections/trunk/checkstyle.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/checkstyle.xml?rev=1477744&r1=1477743&r2=1477744&view=diff
>
> ==============================================================================
> --- commons/proper/collections/trunk/checkstyle.xml (original)
> +++ commons/proper/collections/trunk/checkstyle.xml Tue Apr 30 18:03:28
> 2013
> @@ -68,6 +68,13 @@
> <!-- Constant names should obey the traditional all uppercase
> naming convention -->
> <module name="ConstantName" />
>
> + <!-- No trailing whitespace -->
> + <module name="Regexp">
> + <property name="format" value="[ \t]+$"/>
> + <property name="illegalPattern" value="true"/>
> + <property name="message" value="Trailing whitespace"/>
> + </module>
> +
> <!-- Authors should be in pom.xml file -->
> <module name="Regexp">
> <property name="format" value="@author"/>
>
>
>