You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/07/06 01:51:12 UTC

[GitHub] sijie opened a new pull request #2099: Issue 1455: MessageID has always batch index 0 when sending messages in a batch

sijie opened a new pull request #2099: Issue 1455: MessageID has always batch index 0 when sending messages in a batch
URL: https://github.com/apache/incubator-pulsar/pull/2099
 
 
   
   *Motivation*
   
   Fixes #1455.
   
   Pulsar uses a callback chain for completing the list of callbacks for a batch. However the callback chain doesn't reference the message instance for completing the callback.
   so when callback chain is triggered, it always uses the first message id to complete the chain of callbacks.
   
   *Changes*
   
   Introduce a field to keep message instance in the callback chain. So when the chain is invoked, each callback can use the right message instance to complete the callback.
   
   Added an integration test to ensure it works correctly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services