You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/07 12:56:27 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #16291: Support helm chart to be installed by Argo CD

kaxil commented on a change in pull request #16291:
URL: https://github.com/apache/airflow/pull/16291#discussion_r646561561



##########
File path: chart/templates/jobs/migrate-database-job.yaml
##########
@@ -38,6 +38,9 @@ metadata:
     "helm.sh/hook": post-install,post-upgrade
     "helm.sh/hook-weight": "1"
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
+    "argocd.argoproj.io/hook": Sync
+    "argocd.argoproj.io/sync-wave": "0"
+    "argocd.argoproj.io/hook-delete-policy": BeforeHookCreation,HookSucceeded

Review comment:
       Would it help to allow adding extra annotations as part of `values.yaml`, kind of similar to https://github.com/apache/airflow/blob/bff213e07735d1ee45101f85b01b3d3a97cddbe5/chart/templates/configmaps/configmap.yaml#L34-L37 
   
   ?
   
   cc @jedcunningham 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org