You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/05 03:40:22 UTC

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

yamt opened a new pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800


   Reverts apache/incubator-nuttx-apps#795
   
   because:
   
   * it broke Make.dep
   * the use case is not clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874454975


   @GUIDINGLI @xiaoxiang781216
   how do you think?
   my colleagues are suffering from this Make.dep breakage.
   and IMO the change itself seems rather controversial. it's more common to produce the similar-looking .o regardless of which language the source code is written.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] GUIDINGLI commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874513110


   Here is the fix:
   https://github.com/apache/incubator-nuttx-apps/pull/801
   
   so we don't need revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874454975


   @GUIDINGLI @xiaoxiang781216
   how do you think?
   my colleagues are suffering from this Make.dep breakage.
   and IMO the change itself seems rather controversial. it's more common to produce the similar-looking .o regardless of which language the source code is written.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] GUIDINGLI commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874513110


   Here is the fix:
   https://github.com/apache/incubator-nuttx-apps/pull/801
   
   so we don't need revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #800:
URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874699443


   After the discussion in #801, let's close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org