You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/11/16 02:35:09 UTC

[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2049: [IOTDB-1007]Fix session pool concurrency and leakage issue when pool.close is called

jixuan1989 commented on a change in pull request #2049:
URL: https://github.com/apache/iotdb/pull/2049#discussion_r523865384



##########
File path: session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
##########
@@ -76,6 +76,8 @@
   private boolean enableCompression = false;
   private ZoneId zoneId;
 
+  private boolean closed;//whether the queue is closed.

Review comment:
       but it does not take native effective if a thread sees the value of `closed` with a latency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org