You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "davebarnes97 (GitHub)" <gi...@apache.org> on 2019/01/24 21:37:36 UTC
[GitHub] [geode] davebarnes97 opened pull request #3119: GEODE-6319: User Guide - Clarify that partitioned regions can be crea…
…ted dynamically
Asserted (explicitly) that partitioned regions can be created dynamically, but not through the factory class.
Introduced some format changes.
[ Full content available at: https://github.com/apache/geode/pull/3119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on pull request #3119: GEODE-6319: User Guide - Clarify that partitioned regions can be crea…
Posted by "kirklund (GitHub)" <gi...@apache.org>.
I'd say either direction is ok. Go ahead note that it's deprecated but keep it in place. Maybe the correct time to delete the documentation is in the release that actually deletes the DynamicRegionFactory class.
[ Full content available at: https://github.com/apache/geode/pull/3119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] davebarnes97 closed pull request #3119: GEODE-6319: User Guide - Clarify that partitioned regions can be crea…
Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
[ pull request closed by davebarnes97 ]
[ Full content available at: https://github.com/apache/geode/pull/3119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] davebarnes97 commented on pull request #3119: GEODE-6319: User Guide - Clarify that partitioned regions can be crea…
Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
Thanks, @dschneider-pivotal.
As a courtesy to developers of legacy apps that use the DynamicRegionFactory class, I'm leaving it in place for this iteration, but noting that it's deprecated and demoting it from first position on the page. Future deletion is definitely in order.
[ Full content available at: https://github.com/apache/geode/pull/3119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #3119: GEODE-6319: User Guide - Clarify that partitioned regions can be crea…
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
DynamicRegionFactory has been deprecated in favor of using the function service instead. The javadocs on the class have this: * @deprecated This class is deprecated. Use {@link FunctionService} to create regions on other
* members instead.
So I would use this ticket as an opportunity to remove this reference to DynamicRegionFactory and just keep the part about using function execution to create a region dynamically.
Note that both the class DynamicRegionFactory and the corresponding xml element <dynamic-region-factory> are deprecated so they could be removed in the next major release
[ Full content available at: https://github.com/apache/geode/pull/3119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] joeymcallister commented on issue #3119: GEODE-6319: User Guide - Clarify that partitioned regions can be crea…
Posted by "joeymcallister (GitHub)" <gi...@apache.org>.
+1 to waiting until the class is deleted to remove the documentation of it.
Marking it as deprecated seems like the most appropriate approach here. I
also like Dave's idea to demote/deprioritize it in the documentation page.
That seems like a useful way of getting deprecated classes/features/etc.
out of the reader's way without completely removing them.
On Fri, Jan 25, 2019 at 1:18 PM Kirk Lund <no...@github.com> wrote:
> *@kirklund* commented on this pull request.
> ------------------------------
>
> In
> geode-docs/developing/region_options/dynamic_region_creation.html.md.erb
> <https://github.com/apache/geode/pull/3119#discussion_r251139172>:
>
> > @@ -21,15 +21,20 @@ limitations under the License.
>
> You can dynamically create regions in your application code and automatically instantiate them on members of a cluster.
>
> -If your application does not require partitioned regions, you can use the <span class="keyword apiname">org.apache.geode.cache.DynamicRegionFactory</span> class to dynamically create regions, or you can create them using the `<dynamic-region-factory>` element in the cache.xml file that defines the region. See [<dynamic-region-factory>](../../reference/topics/cache_xml.html#dynamic-region-factory).
> +If your application does not require partitioned regions, you can use the `org.apache.geode.cache.DynamicRegionFactory` class to dynamically create regions, or
>
> I'd say either direction is ok. Go ahead note that it's deprecated but
> keep it in place. Maybe the correct time to delete the documentation is in
> the release that actually deletes the DynamicRegionFactory class.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/3119#discussion_r251139172>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/APXEUZ3wFA3_zphlQbfNpPmgzHdC-k9Eks5vG3S7gaJpZM4aRwnF>
> .
>
[ Full content available at: https://github.com/apache/geode/pull/3119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org