[GitHub] hughhhh commented on a change in pull request #5524: A tagging system for dashboards, charts and queries

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #5524: A tagging system for dashboards, charts and queries
URL: https://github.com/apache/incubator-superset/pull/5524#discussion_r206372312
 
 

 ##########
 File path: superset/views/tags.py
 ##########
 @@ -0,0 +1,198 @@
+# -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import simplejson as json
+
+from flask import Response, request
+from flask_appbuilder import expose
+from jinja2.sandbox import SandboxedEnvironment
+from sqlalchemy import and_, func
+from werkzeug.routing import BaseConverter
+
+from superset import app, appbuilder, db, utils
+from superset.jinja_context import current_user_id, current_username
+from superset.models.sql_lab import SavedQuery
+from superset.models.tags import Tag, TaggedObject, TagTypes, ObjectTypes
+import superset.models.core
+from .base import BaseSupersetView
+
+
+class ObjectTypeConverter(BaseConverter):
 
 Review comment:
   Can we move this to a `utils.py` file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org