You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/14 01:55:42 UTC

[GitHub] [apisix] Firstsawyou commented on a change in pull request #1979: bugfix: empty `allow_admin` means that any IP is allowed to access Admin API and Dashboard

Firstsawyou commented on a change in pull request #1979:
URL: https://github.com/apache/apisix/pull/1979#discussion_r504354046



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -211,8 +211,40 @@ fi
 
 echo "passed: worker_shutdown_timeout in nginx.conf is ok"
 
+# empty allow_admin in conf/config.yaml

Review comment:
       I think the title is not a good title. Because the following example has a situation where ʻallow_admin` is not empty.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org