You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/01 05:59:19 UTC
[GitHub] [incubator-mxnet] reminisce opened a new pull request #17200: [WIP]
loosen numpy version requirement
reminisce opened a new pull request #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17200: [WIP]
loosen numpy version requirement
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200#issuecomment-575321863
Wasn't this downgraded to prevent numpy.decorator issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17200: [WIP] loosen
numpy version requirement
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17200: [WIP]
loosen numpy version requirement
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200#issuecomment-575342644
Any idea which PR should be merged to get 1.5.x into working?
I tried cherry-picking https://github.com/apache/incubator-mxnet/pull/17155/files but ran into merge conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17200: [WIP] loosen
numpy version requirement
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200#issuecomment-575327309
It was also done due to https://github.com/apache/incubator-mxnet/issues/17154
That issue was fixed and no other failing tests found. Thus @reminisce loosened the requirement. Could you link the issue that tracks the remaining problems?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] reminisce commented on issue #17200: [WIP] loosen
numpy version requirement
Posted by GitBox <gi...@apache.org>.
reminisce commented on issue #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200#issuecomment-570112079
@leezu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17200:
[WIP] loosen numpy version requirement
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on issue #17200: [WIP] loosen numpy version requirement
URL: https://github.com/apache/incubator-mxnet/pull/17200#issuecomment-575321863
Wasn't numpy version restriction (<1.18) done to prevent numpy.decorator issue? @leezu @reminisce
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services