You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/19 06:06:39 UTC

[GitHub] [pulsar] rdhabalia commented on a change in pull request #9212: [pulsar-broker] Fix: handle topic loading failure due to broken schema ledger

rdhabalia commented on a change in pull request #9212:
URL: https://github.com/apache/pulsar/pull/9212#discussion_r559933045



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##########
@@ -41,6 +41,8 @@
 
     CompletableFuture<SchemaVersion> deleteSchemaStorage(String schemaId);
 
+    CompletableFuture<SchemaVersion> deleteSchemaStorage(String schemaId, boolean forcefully);

Review comment:
       that will be tricky because `deleteSchemaStorage(schemaId)` calls `deleteSchemaStorage(schemaId, false)` . and we can't define default behavior of `deleteSchemaStorage(schemaId, false)` by calling existing `deleteSchemaStorage(schemaId)` because it creates cyclic call.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org